[Buildbot-commits] [Buildbot] #960: Convert all buildbot classes to new style, i.e. inherit from object.

[Buildbot]

#960: Convert all buildbot classes to new style, i.e. inherit from object.
-------------------+--------------------------------------------------------
Reporter:  maruel  |       Owner:       
    Type:  task    |      Status:  new  
Priority:  major   |   Milestone:  0.8.+
 Version:  0.8.1   |    Keywords:  tests
-------------------+--------------------------------------------------------
Changes (by dustin):

  * keywords:  tests, ship-this => tests
  * milestone:  0.8.3 => 0.8.+


Comment:

 This fails badly when unpickling builds from previous versions.  Comments
 on the commit -
 http://github.com/catlee/buildbot/commit/0593a9dbff1ccc286b06cbbcac3408e7d996b4ae#commitcomment-183550.

 One option is to write some sort of conversion code into the unpickling.
 The other option is to wait for the StatusDB when we're not using pickles
 anymore. I prefer the latter, honestly..

 Also, I'm not so keen on tests looking at the sizes of the classes before
 and after.  It's nice to demonstrate that this has a savings and so on,
 but it doesn't really constitute a unit test - more of a performance test,
 I guess.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/960#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation