[Buildbot-commits] [SPAM] Re: [Buildbot] #867: p4 poller triggers assertion in _process_changes(self, result) and no more builds are scheduled

[Buildbot]

#867: p4 poller triggers assertion in _process_changes(self, result) and no more
builds are scheduled
-------------------+--------------------------------------------------------
Reporter:  phil    |       Owner:             
    Type:  defect  |      Status:  new        
Priority:  major   |   Milestone:  undecided  
 Version:  0.7.12  |    Keywords:  p4 p4poller
-------------------+--------------------------------------------------------
Description changed by dustin:

Old description:

> Error output:
> [-] P4 poll failed: [Failure instance: Traceback:
> exceptions.AssertionError: Invalid file line: '... //depot/testbad#1
> move/add'
>

> Description:
> The "p4 describe -s changelistnumber" command can contain changelist
> entries such as:
>
> "... //depot/testok#1 edit"
> "... //depot/testbad#1 move/add"
> "... //depot/testbad2#1 move/delete"
>
> The regex for the changelist lines is incorrect if the changelist entries
> are ending with "move/add" or "move/delete" instead of just "edit" or
> "add". More specifically the '/' is missing in the regex expression.
>
> Proposed solution (based on p4poller.py 0.7.12):
> change p4poller.py(37):
>     file_re = re.compile(r"^\.\.\. (?P<path>[^#]+)#\d+ \w+$")
> into
>     file_re = re.compile(r"^\.\.\. (?P<path>[^#]+)#\d+ [\w/]+$")

New description:

 Error output:
 [-] P4 poll failed: [Failure instance: Traceback:
 exceptions.AssertionError: Invalid file line: '... //depot/testbad#1
 move/add'


 Description:
 The "p4 describe -s changelistnumber" command can contain changelist
 entries such as:

 "... //depot/testok#1 edit"
 "... //depot/testbad#1 move/add"
 "... //depot/testbad2#1 move/delete"

 The regex for the changelist lines is incorrect if the changelist entries
 are ending with "move/add" or "move/delete" instead of just "edit" or
 "add". More specifically the '/' is missing in the regex expression.

 Proposed solution (based on p4poller.py 0.7.12):
 change p4poller.py(37):
 {{{
     file_re = re.compile(r"^\.\.\. (?P<path>[^#]+)#\d+ \w+$")
 }}}
 into
 {{{
     file_re = re.compile(r"^\.\.\. (?P<path>[^#]+)#\d+ [\w/]+$")
 }}}

--

-- 
Ticket URL: <http://buildbot.net/trac/ticket/867#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation