[Buildbot-commits] [SPAM] Re: [Buildbot] #864: Error on CVS repository update : None passed as revision

[Buildbot]

#864: Error on CVS repository update : None passed as revision
---------------------------+------------------------------------------------
Reporter:  GillesGagniard  |       Owner:           
    Type:  defect          |      Status:  new      
Priority:  major           |   Milestone:  undecided
 Version:  0.8.0           |    Keywords:  cvs      
---------------------------+------------------------------------------------

Comment(by GillesGagniard):

 The problem lies in the constructor of SourceStamp :

         if changes:
             self.changes = tuple(changes)
             # set branch and revision to most recent change
             self.branch = changes[-1].branch
             self.revision = str(changes[-1].revision)
             if not self.project:
                 self.project = changes[-1].project
             if not self.repository:
                 self.repository = changes[-1].repository

 However, for changes coming from CVS, the revision attribute for changes
 is None, and thus

 self.revision = str(changes[-1].revision)

 is 'None', and not None. Since it is not None, the computeSourceRevision()
 method in the CVS buildstep is never called.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/864#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation