[Buildbot-commits] [SPAM] Re: [Buildbot] #389: "Stop Build" button reports error when pressed before steps are started

[Buildbot]

#389: "Stop Build" button reports error when pressed before steps are started
----------------------+-----------------------------------------------------
Reporter:  mmacvicar  |       Owner:       
    Type:  defect     |      Status:  new  
Priority:  major      |   Milestone:  0.8.1
 Version:  0.7.7      |    Keywords:       
----------------------+-----------------------------------------------------
Changes (by dustin):

  * keywords:  slave lock stop build =>
  * priority:  minor => major
  * milestone:  0.8.+ => 0.8.1


Old description:

> "Stop Build" button reports error when pressed before steps are started
>
> If you are using slave locks, the builds appear on the waterfall while
> they wait for the slave to unlock. You can click on the build and press
> the "stop build" button, but that reports this error:
>
> /usr/local/lib/python2.5/site-packages/buildbot/process/base.py, line 500
> in stopBuild
> 498    # TODO: include 'reason' in this point event
> 499    self.builder.builder_status.addPointEvent(['interrupt'])
> 500    self.currentStep.interrupt(reason)
> 501    if 0:
> Selfbuilder buildbot.process.builder.Builder instance @ 0x9745d0c
>  <Builder 'CausticGLES Linux_x86_32 Release' at 158620940>
> currentStep None
>
> Localsreason "The web-page 'stop build' button was pressed by
> 'mark.macvicar': cancelling build for system upgrade\n"
> self buildbot.process.base.Build instance @ 0x98a8f8c
>  <Build CausticGLES Linux_x86_32 Release>
>
> <type 'exceptions.AttributeError'>: 'NoneType' object has no attribute
> 'interrupt'

New description:

 "Stop Build" button reports error when pressed before steps are started

 If you are using slave locks, the builds appear on the waterfall while
 they wait for the slave to unlock. You can click on the build and press
 the "stop build" button, but that reports this error:

 {{{
 /usr/local/lib/python2.5/site-packages/buildbot/process/base.py, line 500
 in stopBuild
 498    # TODO: include 'reason' in this point event
 499    self.builder.builder_status.addPointEvent(['interrupt'])
 500    self.currentStep.interrupt(reason)
 501    if 0:
 Selfbuilder buildbot.process.builder.Builder instance @ 0x9745d0c
  <Builder 'CausticGLES Linux_x86_32 Release' at 158620940>
 currentStep None

 Localsreason "The web-page 'stop build' button was pressed by
 'mark.macvicar': cancelling build for system upgrade\n"
 self buildbot.process.base.Build instance @ 0x98a8f8c
  <Build CausticGLES Linux_x86_32 Release>

 <type 'exceptions.AttributeError'>: 'NoneType' object has no attribute
 'interrupt'
 }}}

--

-- 
Ticket URL: <http://buildbot.net/trac/ticket/389#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation