[Buildbot-commits] [SPAM] Re: [Buildbot] #827: ChangeSources may produce changes containing non-unicode strings

[Buildbot]

#827: ChangeSources may produce changes containing non-unicode strings
---------------------+------------------------------------------------------
Reporter:  dustin    |       Owner:       
    Type:  defect    |      Status:  new  
Priority:  critical  |   Milestone:  0.8.1
 Version:  0.7.12    |    Keywords:       
---------------------+------------------------------------------------------

Comment(by willw):

 I think our p4poller just ran into this issue yesterday - causing it to
 stop working:

 {
 2010-05-18 12:28:36+0200 [-] adding change, who claire, 1 files,
 rev=400373, branch=trunk repository=, comments Change 400373 by
 claire at fft_claire on 2010/05/18 12:25:54

                 !B - Fix
                 Review: ID 22330 by Márcio Martins

         , category None
 2010-05-18 12:28:36+0200 [-] P4 poll failed
         Traceback (most recent call last):
           File "/usr/lib/python2.5/site-
 packages/Twisted-10.0.0-py2.5-linux-x86_64.egg/twisted/internet/defer.py",
 line 354, in _startRunCallbacks
             self._runCallbacks()
           File "/usr/lib/python2.5/site-
 packages/Twisted-10.0.0-py2.5-linux-x86_64.egg/twisted/internet/defer.py",
 line 371, in _runCallbacks
             self.result = callback(self.result, *args, **kw)
           File "/usr/lib/python2.5/site-
 packages/Twisted-10.0.0-py2.5-linux-x86_64.egg/twisted/internet/defer.py",
 line 330, in _continue
             self.unpause()
           File "/usr/lib/python2.5/site-
 packages/Twisted-10.0.0-py2.5-linux-x86_64.egg/twisted/internet/defer.py",
 line 325, in unpause
             self._runCallbacks()
         --- <exception caught here> ---
           File "/usr/lib/python2.5/site-
 packages/Twisted-10.0.0-py2.5-linux-x86_64.egg/twisted/internet/defer.py",
 line 371, in _runCallbacks
             self.result = callback(self.result, *args, **kw)
           File "/usr/lib/python2.5/site-
 packages/buildbot-0.8.0rc2-py2.5.egg/buildbot/changes/p4poller.py", line
 222, in _process_describe
             self.parent.addChange(c)
           File "/usr/lib/python2.5/site-
 packages/buildbot-0.8.0rc2-py2.5.egg/buildbot/changes/manager.py", line
 113, in addChange
             self.parent.addChange(change)
           File "/usr/lib/python2.5/site-
 packages/buildbot-0.8.0rc2-py2.5.egg/buildbot/master.py", line 1035, in
 addChange
             self.db.addChangeToDatabase(change)
           File "/usr/lib/python2.5/site-
 packages/buildbot-0.8.0rc2-py2.5.egg/buildbot/db/connector.py", line 306,
 in addChangeToDatabase
             self.runInteractionNow(self._txn_addChangeToDatabase, change)
           File "/usr/lib/python2.5/site-
 packages/buildbot-0.8.0rc2-py2.5.egg/buildbot/db/connector.py", line 210,
 in runInteractionNow
             return self._runInteractionNow(interaction, *args, **kwargs)
           File "/usr/lib/python2.5/site-
 packages/buildbot-0.8.0rc2-py2.5.egg/buildbot/db/connector.py", line 235,
 in _runInteractionNow
             result = interaction(c, *args, **kwargs)
           File "/usr/lib/python2.5/site-
 packages/buildbot-0.8.0rc2-py2.5.egg/buildbot/db/connector.py", line 324,
 in _txn_addChangeToDatabase
             t.execute(q, values)
         pysqlite2.dbapi2.ProgrammingError: You must not use 8-bit
 bytestrings unless you use a text_factory that can interpret 8-bit
 bytestrings (like text_factory = str). It is highly recommended that you
 instead just switch your application to Unicode strings.

 }

 Is it safe for us just to apply the fix above?

-- 
Ticket URL: <http://buildbot.net/trac/ticket/827#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation