[Buildbot-commits] [djmitche/buildbot] 0b7f43: Refactored to be able to test email creation.

noreply at github.com noreply at github.com
Sat Mar 13 16:49:06 UTC 2010


Branch: refs/heads/master
Home:   http://github.com/djmitche/buildbot

Commit: 0b7f431b4de24291f125cd79627679eceb60a97e
    http://github.com/djmitche/buildbot/commit/0b7f431b4de24291f125cd79627679eceb60a97e
Author: Mattias Brändström <thebrasse at brasse.org>
Date:   2010-03-12 (Fri, 12 Mar 2010)

Changed paths:
  M buildbot/status/mail.py
  A buildbot/test/unit/test_status_mail_MailNotifier.py

Log Message:
-----------
Refactored to be able to test email creation.

Added MailNotofier.createEmail(). This method creates an email.Message
instance, with the appropriate content, and returns it. Before this
change the code in createEmail() was located inside buildMessage().

When we have this new method it becomes easy to write a test that
verifies that emails gets created correctly in the presence of non-ascii
unicode characters. Correctly in this context means that we can call
message.as_string() without a UnicodeEncodeError being raised.


Commit: 5f9b2e7193f0f655e4d21cb3e52351de27684457
    http://github.com/djmitche/buildbot/commit/5f9b2e7193f0f655e4d21cb3e52351de27684457
Author: Mattias Brändström <thebrasse at brasse.org>
Date:   2010-03-12 (Fri, 12 Mar 2010)

Changed paths:
  M buildbot/status/mail.py
  M buildbot/test/unit/test_status_mail_MailNotifier.py

Log Message:
-----------
Fixed email creation bug in MailNotifier.

All text is now encoded as utf8 before it goes into the message object.


Commit: 0fb4d4d437489ffb5f29fed6901241151d0bf7a0
    http://github.com/djmitche/buildbot/commit/0fb4d4d437489ffb5f29fed6901241151d0bf7a0
Author: Dustin J. Mitchell <dustin at zmanda.com>
Date:   2010-03-13 (Sat, 13 Mar 2010)

Changed paths:
  M buildbot/status/mail.py
  A buildbot/test/unit/test_status_mail_MailNotifier.py

Log Message:
-----------
Merge branch 'master' of git://github.com/brasse/buildbot

* 'master' of git://github.com/brasse/buildbot:
  Fixed email creation bug in MailNotifier.
  Refactored to be able to test email creation.


Commit: 7cc0ceb0ca96cd72fcf5e70d38c913fae92b2bff
    http://github.com/djmitche/buildbot/commit/7cc0ceb0ca96cd72fcf5e70d38c913fae92b2bff
Author: Dustin J. Mitchell <dustin at zmanda.com>
Date:   2010-03-13 (Sat, 13 Mar 2010)

Changed paths:
  M buildbot/test/unit/test_status_mail_MailNotifier.py

Log Message:
-----------
use explicit \uXXXX for embedded unicode characters






More information about the Commits mailing list