[Buildbot-commits] [djmitche/buildbot] 21296a: remove overzealous escaping of reason in rebuild()
noreply at github.com
noreply at github.com
Fri Mar 12 06:56:48 UTC 2010
Branch: refs/heads/buildbot-0.8.0
Home: http://github.com/djmitche/buildbot
Commit: 21296a797c53ce8a855978d4cbdacf6950623a0a
http://github.com/djmitche/buildbot/commit/21296a797c53ce8a855978d4cbdacf6950623a0a
Author: Dustin J. Mitchell <dustin at zmanda.com>
Date: 2010-03-11 (Thu, 11 Mar 2010)
Changed paths:
M buildbot/status/web/build.py
Log Message:
-----------
remove overzealous escaping of reason in rebuild()
I'd like a second look at this, since these escapes were added while
resolving the XSS vulnerabilities back in 0.7.*. I think they are
unnecessary, particularly with the use of Jinja. I suspect they were
added out of an abundance of caution, lest the reason later be used
unescaped in a status display.
More information about the Commits
mailing list