[Buildbot-commits] [SPAM] [Buildbot] #909: Support setting of LineEnd perforce client specification property

Buildbot buildbot-devel at lists.sourceforge.net
Tue Jun 29 13:12:38 UTC 2010


#909: Support setting of LineEnd perforce client specification property
--------------------------+-------------------------------------------------
Reporter:  thomasthorsen  |       Owner:           
    Type:  enhancement    |      Status:  new      
Priority:  trivial        |   Milestone:  undecided
 Version:  0.8.0          |    Keywords:  p4       
--------------------------+-------------------------------------------------
 Currently this is hardcoded to "local" in the P4 class
 (slave/commands/vcs.py):

 client_spec += "LineEnd:\tlocal\n\n"

 Out of necessity to change this to "share" to preserve UNIX line endings
 on our test systems, I made this change to the python files so that it is
 properly parameterized, so you can set it to whatever is required when
 using the P4 class. The change is of course backward compatible so the
 behaviour is unchanged if this (optional) extra parameter is not
 specified.

 The change involves only a few extra lines in the two files:
 slave/commands/vcs.py
 steps/source.py

 I've attached the two modified files.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/909>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list