[Buildbot-commits] [SPAM] Re: [Buildbot] #900: console: exceptions everywhere

[Buildbot]

#900: console: exceptions everywhere
-------------------+--------------------------------------------------------
Reporter:  axel    |       Owner:       
    Type:  defect  |      Status:  new  
Priority:  major   |   Milestone:  0.8.1
 Version:  0.8.0   |    Keywords:  web  
-------------------+--------------------------------------------------------
Changes (by dustin):

  * keywords:  console pink exception => web
  * milestone:  undecided => 0.8.1


Old description:

> Hi,
>
> for me, all console builds are pink. Debugging showed that results in
> getResultsClass() was in fact a list. I changed console.py to
>
> --- status/web/console.py.org   2010-05-24 17:31:03.000000000 +0200
> +++ status/web/console.py       2010-06-18 12:15:11.328747895 +0200
> @@ -19,9 +19,15 @@
>      if results is None:
>          return "notstarted"
>
> +    if type(results) in (tuple, list):
> +        results = max(results)
> +
>      if results == builder.SUCCESS:
>          return "success"
>

> and now it works.
>
> While at it, I added "warnings" as a legal result:
>
> --- status/web/console.py.org   2010-05-24 17:31:03.000000000 +0200
> +++ status/web/console.py       2010-06-18 12:15:11.328747895 +0200
> @@ -19,9 +19,15 @@
>      if results is None:
>          return "notstarted"
>
> +    if type(results) in (tuple, list):
> +        results = max(results)
> +
>      if results == builder.SUCCESS:
>          return "success"
>
> +    if results == builder.WARNINGS:
> +        return "warnings"
> +
>      if results == builder.FAILURE:
>          if not prevResults:
>              # This is the bottom box. We don't know if the previous one
> failed
>

> Cheers, Axel.

New description:

 Hi,

 for me, all console builds are pink. Debugging showed that results in
 getResultsClass() was in fact a list. I changed console.py to

 {{{
 #!patch
 --- status/web/console.py.org   2010-05-24 17:31:03.000000000 +0200
 +++ status/web/console.py       2010-06-18 12:15:11.328747895 +0200
 @@ -19,9 +19,15 @@
      if results is None:
          return "notstarted"

 +    if type(results) in (tuple, list):
 +        results = max(results)
 +
      if results == builder.SUCCESS:
          return "success"
  }}}

 and now it works.

 While at it, I added "warnings" as a legal result:

 {{{
 #!patch
 --- status/web/console.py.org   2010-05-24 17:31:03.000000000 +0200
 +++ status/web/console.py       2010-06-18 12:15:11.328747895 +0200
 @@ -19,9 +19,15 @@
      if results is None:
          return "notstarted"

 +    if type(results) in (tuple, list):
 +        results = max(results)
 +
      if results == builder.SUCCESS:
          return "success"

 +    if results == builder.WARNINGS:
 +        return "warnings"
 +
      if results == builder.FAILURE:
          if not prevResults:
              # This is the bottom box. We don't know if the previous one
 failed
 }}}

 Cheers, Axel.

--

Comment:

 (reformat description)

-- 
Ticket URL: <http://buildbot.net/trac/ticket/900#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation