[Buildbot-commits] [SPAM] [Buildbot] #929: Visual Studio steps not working in v 0.8.1

[Buildbot]

#929: Visual Studio steps not working in v 0.8.1
-------------------+--------------------------------------------------------
Reporter:  cowo    |       Owner:       
    Type:  defect  |      Status:  new  
Priority:  major   |   Milestone:  0.8.2
 Version:  0.8.1   |    Keywords:       
-------------------+--------------------------------------------------------
 Buildbot v0.8.1 / activepython 2.6 / windows 7 for both master and slave,
 visual studio 2008.

 If I create a step like

 {{{
 s2 = VC8(
   mode = "rebuild",
   projectfile = "msvc/solution.sln",
   config = "Release",
   installdir = "msvc_base_installation",
   useenv = False,
   arch = "x86"
 )
 }}}


 When the step is then evaluated on the slave it yields:
 {{{
 devenv None /Rebuild None
  in dir C:\Devel\Buildslave\libCopan-C++\build (timeout 1200 secs)
  watching logfiles {}
  argv: ['devenv', 'None', '/Rebuild', 'None']
  environment:
 }}}
 Properties like "projectfile" somehow are lost.
 Turns out that the !VisualStudio steps don't issue a call to
 self.addFactoryArguments()
 [[BR]]
 I'm attaching a patch against 0.8.1 code that SEEMS to solve the problem
 (tested a couple of times). Also adds support for VCExpress 2008.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/929>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation