[Buildbot-commits] [SPAM] Re: [Buildbot] #927: ChangeFilter branch_re causes exception

[Buildbot]

#927: ChangeFilter branch_re causes exception
---------------------+------------------------------------------------------
Reporter:  Hbot      |       Owner:       
    Type:  defect    |      Status:  new  
Priority:  critical  |   Milestone:  0.8.2
 Version:  0.8.1     |    Keywords:       
---------------------+------------------------------------------------------
Changes (by dustin):

  * keywords:  ChangeFilter branch_re exception =>


Old description:

> (See also http://pastebin.com/HmgN2Set )
>
> buildbot 0.8.1 , Python 2.6.5 , Ubuntu 10.04-server
>
> Changing :
>
> test1_branch1_filter = ChangeFilter(
>     repository="test1",
>     branch="branches/branch1",
> )
>
> into :
>
> test1_branch1_filter = ChangeFilter(
>     repository_re=".*test1.*",
>     branch_re=".*branches/branch1.*",
> )
>
> causes :
>
> 2010-07-20 10:28:43+0000 [-] Unhandled Error
>         Traceback (most recent call last):
>           File "/usr/lib/python2.6/threading.py", line 504, in
> __bootstrap
>             self.__bootstrap_inner()
>           File "/usr/lib/python2.6/threading.py", line 532, in
> __bootstrap_inner
>             self.run()
>           File "/usr/lib/python2.6/threading.py", line 484, in run
>             self.__target(*self.__args, **self.__kwargs)
>         --- <exception caught here> ---
>           File "/usr/lib/python2.6/dist-
> packages/twisted/python/threadpool.py", line 210, in _worker
>             result = context.call(ctx, function, *args, **kwargs)
>           File "/usr/lib/python2.6/dist-
> packages/twisted/python/context.py", line 59, in callWithContext
>             return self.currentContext().callWithContext(ctx, func,
> *args, **kw)
>           File "/usr/lib/python2.6/dist-
> packages/twisted/python/context.py", line 37, in callWithContext
>             return func(*args,**kw)
>           File "/usr/lib/python2.6/dist-
> packages/twisted/enterprise/adbapi.py", line 429, in _runInteraction
>             result = interaction(trans, *args, **kw)
>           File "/usr/local/lib/python2.6/dist-
> packages/buildbot/schedulers/base.py", line 143, in classify_changes
>             if self.change_filter.filter_change(c):
>           File "/usr/local/lib/python2.6/dist-
> packages/buildbot/schedulers/filter.py", line 54, in filter_change
>             if filt_re is not None and not filt_re.match(chg_val):
>         exceptions.TypeError: expected string or buffer
>
> Further testing shows it's the branch_re causing this. The repository_re
> is fine and works.

New description:

 (See also http://pastebin.com/HmgN2Set )

 buildbot 0.8.1 , Python 2.6.5 , Ubuntu 10.04-server

 Changing :
 {{{
 test1_branch1_filter = ChangeFilter(
     repository="test1",
     branch="branches/branch1",
 )
 }}}
 into :
 {{{
 test1_branch1_filter = ChangeFilter(
     repository_re=".*test1.*",
     branch_re=".*branches/branch1.*",
 )
 }}}
 causes :
 {{{
 2010-07-20 10:28:43+0000 [-] Unhandled Error
         Traceback (most recent call last):
           File "/usr/lib/python2.6/threading.py", line 504, in __bootstrap
             self.__bootstrap_inner()
           File "/usr/lib/python2.6/threading.py", line 532, in
 __bootstrap_inner
             self.run()
           File "/usr/lib/python2.6/threading.py", line 484, in run
             self.__target(*self.__args, **self.__kwargs)
         --- <exception caught here> ---
           File "/usr/lib/python2.6/dist-
 packages/twisted/python/threadpool.py", line 210, in _worker
             result = context.call(ctx, function, *args, **kwargs)
           File "/usr/lib/python2.6/dist-
 packages/twisted/python/context.py", line 59, in callWithContext
             return self.currentContext().callWithContext(ctx, func, *args,
 **kw)
           File "/usr/lib/python2.6/dist-
 packages/twisted/python/context.py", line 37, in callWithContext
             return func(*args,**kw)
           File "/usr/lib/python2.6/dist-
 packages/twisted/enterprise/adbapi.py", line 429, in _runInteraction
             result = interaction(trans, *args, **kw)
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot/schedulers/base.py", line 143, in classify_changes
             if self.change_filter.filter_change(c):
           File "/usr/local/lib/python2.6/dist-
 packages/buildbot/schedulers/filter.py", line 54, in filter_change
             if filt_re is not None and not filt_re.match(chg_val):
         exceptions.TypeError: expected string or buffer
 }}}
 Further testing shows it's the branch_re causing this. The repository_re
 is fine and works.

--

-- 
Ticket URL: <http://buildbot.net/trac/ticket/927#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation