[Buildbot-commits] [SPAM] Re: [Buildbot] #676: CVS export options ignored by slave

[Buildbot]

#676: CVS export options ignored by slave
-----------------------+----------------------------------------------------
Reporter:  satyagraha  |        Owner:        
    Type:  defect      |       Status:  closed
Priority:  major       |    Milestone:  0.8.0 
 Version:  0.7.11      |   Resolution:  fixed 
Keywords:              |  
-----------------------+----------------------------------------------------

Comment(by warner):

 This patch causes test_vc to fail on my OS-X 10.6 box (CVS version
 1.12.13), because it causes a "-P" (prune empty directories) option to be
 passed to "cvs export", which does not accept it.

 satyagraha: did this unit test pass for you before you submitted this
 patch?

 I suppose that any given installation is likely to stick to either
 mode=export or mode=checkout, and so it doesn't much matter that there are
 some {{{checkout_options}}} that are acceptable to one command but not the
 other. On the other hand, the option name ("'''checkout'''_options) makes
 less sense if it's being used for both "checkout" and "export". We could
 either rename it to just plain "cvs_options", or create a new
 "export_options" that only gets used for export.

 At the very least, the unit tests need to pass, and there needs to be a
 note in the buildbot docs explaining what {{{checkout_options}}} are for
 (and that they are used for both {{{checkout}}} and {{{export}}}).

-- 
Ticket URL: <http://buildbot.net/trac/ticket/676#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation