[Buildbot-commits] [SPAM] Re: [Buildbot] #356: doxygen build step

[Buildbot]

#356: doxygen build step
------------------------+---------------------------------------------------
Reporter:  ashcrow      |        Owner:  ashcrow 
    Type:  enhancement  |       Status:  assigned
Priority:  minor        |    Milestone:  0.8.+   
 Version:  0.7.9        |   Resolution:          
Keywords:               |  
------------------------+---------------------------------------------------

Comment(by bradh):

 I had some trouble with the unit tests. It dies with this:
 {{{
 [ERROR]: buildbot.test.test_docsteps

 Traceback (most recent call last):
   File "/usr/lib/python2.6/site-
 packages/Twisted-9.0.0-py2.6-linux-i686.egg/twisted/trial/runner.py", line
 651, in loadByNames
     things.append(self.findByName(name))
   File "/usr/lib/python2.6/site-
 packages/Twisted-9.0.0-py2.6-linux-i686.egg/twisted/trial/runner.py", line
 461, in findByName
     return reflect.namedAny(name)
   File "/usr/lib/python2.6/site-
 packages/Twisted-9.0.0-py2.6-linux-i686.egg/twisted/python/reflect.py",
 line 462, in namedAny
     topLevelPackage = _importAndCheckStack(trialname)
   File "/usr/lib/python2.6/site-packages/buildbot-latest-
 py2.6.egg/buildbot/test/test_docsteps.py", line 8, in <module>
     from buildbot.steps import docs
 exceptions.ImportError: cannot import name docs
 }}}

 My workaround (I'm not sure it qualifies as a "fix") was to do this:
 {{{
 index ff2d9dc..f883387 100644
 --- a/buildbot/test/test_docsteps.py
 +++ b/buildbot/test/test_docsteps.py
 @@ -1,3 +1,4 @@
 +# -*- coding: utf-8 -*-
  #-*- test-case-name: buildbot.test.test_docsteps -*-


 @@ -5,8 +6,7 @@ import os

  from twisted.trial import unittest

 -from buildbot.steps import docs
 -from buildbot.steps.docs import errors
 +from buildbot.steps.docs import DocStep, DocCommandStep, errors
  from buildbot.steps.docs.doxygen import Doxygen
  from buildbot.steps.docs.epydoc import Epydoc

 @@ -20,7 +20,7 @@ class DocStepTest(unittest.TestCase):
          """
          Setup the test.
          """
 -        self.ds = docs.DocStep()
 +        self.ds = DocStep()

      def testCheckForBinary(self):
          """
 @@ -68,16 +68,16 @@ class DocCommandStepTest(unittest.TestCase):
          Verifies that construction works and fails when it should.
          """
          # Successes
 -        docs.DocCommandStep('.')
 -        docs.DocCommandStep('/some/fake/path', ignore_missing_bin=True)
 +        DocCommandStep('.')
 +        DocCommandStep('/some/fake/path', ignore_missing_bin=True)

          # Failures
          self.assertRaises(errors.NoDocumentationBinaryError,
 -            docs.DocCommandStep, '')
 +            DocCommandStep, '')
          self.assertRaises(errors.NoDocumentationBinaryError,
 -            docs.DocCommandStep, 'sdfsfd')
 +            DocCommandStep, 'sdfsfd')
          self.assertRaises(errors.NoDocumentationBinaryError,
 -            docs.DocCommandStep, 'test_docsteps.py')
 +            DocCommandStep, 'test_docsteps.py')


  class DoxygenTest(unittest.TestCase):
 }}}

-- 
Ticket URL: <http://buildbot.net/trac/ticket/356#comment:10>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation