[Buildbot-commits] [djmitche/buildbot] 5d41ee: fix thread leak, fix sqlite errors on shutdown, ad...

[noreply at github.com]

Branch: refs/heads/master
Home:   http://github.com/djmitche/buildbot

Commit: 5d41eef3718b79c034cab533f18354ad87f30f31
    http://github.com/djmitche/buildbot/commit/5d41eef3718b79c034cab533f18354ad87f30f31
Author: Dustin J. Mitchell <dustin at zmanda.com>
Date:   2010-02-20 (Sat, 20 Feb 2010)

Changed paths:
  M buildbot/db.py
  M buildbot/master.py
  M buildbot/test/unit/test_db.py

Log Message:
-----------
fix thread leak, fix sqlite errors on shutdown, add tests

This fixes a major thread leak, by ensuring that the ConnectionPool's
close() method always gets called (fixes #722).  That method was
triggering spurious errors from sqlite, but passing
check_same_thread=False fixes that (and fixes #714).  This also
represents further work on #725 by adding new, well-isolated tests