[Buildbot-commits] [SPAM] Re: [Buildbot] #722: buildbot.db leaks threads

Buildbot buildbot-devel at lists.sourceforge.net
Sun Feb 21 04:08:24 UTC 2010


#722: buildbot.db leaks threads
-----------------------------------+----------------------------------------
Reporter:  dustin                  |        Owner:        
    Type:  defect                  |       Status:  closed
Priority:  blocker                 |    Milestone:  0.8.0 
 Version:  master (give git sha1)  |   Resolution:  fixed 
Keywords:                          |  
-----------------------------------+----------------------------------------
Changes (by Dustin J. Mitchell):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 fix thread leak, fix sqlite errors on shutdown, add tests

 This fixes a major thread leak, by ensuring that the ConnectionPool's
 close() method always gets called (fixes #722).  That method was
 triggering spurious errors from sqlite, but passing
 check_same_thread=False fixes that (and fixes #714).  This also
 represents further work on #725 by adding new, well-isolated tests
  Changeset: 5d41eef3718b79c034cab533f18354ad87f30f31

-- 
Ticket URL: <http://buildbot.net/trac/ticket/722#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list