[Buildbot-commits] [SPAM] [Buildbot] #704: Further jinjafy /json, and use a common set of asDict-style methods on statuses

Buildbot buildbot-devel at lists.sourceforge.net
Fri Feb 12 20:30:44 UTC 2010


#704: Further jinjafy /json, and use a common set of asDict-style methods on
statuses
-----------------------------------+----------------------------------------
Reporter:  dustin                  |       Owner:       
    Type:  enhancement             |      Status:  new  
Priority:  major                   |   Milestone:  0.8.+
 Version:  master (give git sha1)  |    Keywords:       
-----------------------------------+----------------------------------------
 See:
 http://github.com/djmitche/buildbot/commit/4c019d6053cbf226334a6d13794c680df064077b#comment_47652

 ---

  marcusl about 2 hours ago | delete
 The htmlDict() function that many of these has wasn't good enough? It
 feels a bit silly to have two return-as-dict functions in change and
 sourcestamp.

 Maybe the jinja-templates need some modification to suit the json-stuff,
 but surely we could re-use more code here, no?

 Most WebStatus pages build plain dicts, and I had planned to implement
 some logic to optionally return a json string based on that.

  maruel about an hour ago | delete
 html_dict() wasn't on 0.7.12 and I wrote it on top of that release since
 we're already using it.

 I had standardized asDict() accross all the *Status objects. I don't mind
 either way. The json status is already written btw.
 ---

-- 
Ticket URL: <http://buildbot.net/trac/ticket/704>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list