[Buildbot-commits] [SPAM] Re: [Buildbot] #669: Clean up VC modes

[Buildbot]

#669: Clean up VC modes
------------------------+---------------------------------------------------
Reporter:  dustin       |        Owner:  dustin
    Type:  enhancement  |       Status:  new   
Priority:  critical     |    Milestone:  0.8.0 
 Version:  0.7.11       |   Resolution:        
Keywords:               |  
------------------------+---------------------------------------------------

Comment(by maruel):

 Assuming the user only cares about the end result and the Source step
 shall do whatever is necessary to attain that goal, that means removing
 anything but {{{mode=update}}} and {{{mode=clobber}}} and reducing the
 number of parameters, especially {{{ignore_ignores}}} and
 {{{always_purge}}}.

 I don't think there isn't much use in {{{export}}}. It's nice for sake of
 completeness but that's pretty much it. There isn't point in maintaining
 code that nobody uses.

 We'd like to differentiate between a clobber that keeps the ignored files
 and directories and one that doesn't. The use case to keep the ignored
 files is:
 « For chromium's try server, we svn:ignore the output directory so we
 clobber the local changes but the output directory is kept. »

 I don't exactly know the use case to not keep ignored files. Maybe it's
 not really necessary? One use case for ignoring ignored files is when
 switching branches.

 If we keep all 3 modes; to reduce confusion, we'd change the names to:
   * {{{incremental}}}} is same as update. Don't try to revert any local
 change. Try to reuse existing checkout.
   * {{{clean}}} is the same as clobber {{{ignore_ignores=False}}}.
   * {{{fresh}}} is the same as clobber {{{ignore_ignores=True}}}.

 {{{mode=copy}}} isn't necessary with svn anymore since correct reverting
 code has been added into 0.7.12. git doesn't have issue with that. I don't
 know about the other SCMs, for example, if {{{mode=fresh}}} can't be
 implement in CVS, it should just be implemented with the same code that
 {{{mode=copy}}} used.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/669#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation