[Buildbot-commits] [Buildbot] #1056: handle encodings of change_files properly

Buildbot nobody at buildbot.net
Fri Dec 31 05:26:41 UTC 2010


#1056: handle encodings of change_files properly
-------------------------------+---------------------
Reporter:  dustin              |       Owner:  dustin
    Type:  enhancement         |      Status:  new
Priority:  major               |   Milestone:  0.8.4
 Version:  0.8.2               |  Resolution:
Keywords:  encoding, database  |
-------------------------------+---------------------

Comment (by dustin):

 As to the topic of this ticket - filenames should be unicode strings, full
 stop.  If that ends up confusing other components that Buildbot interacts
 with, we'll figure out ways through/around that when the time comes.

 As for your particular situation, you should be able to use the
 fix_changes_pickle_encoding.py script to do what you tried to do with your
 script.  The issue with your script is that it's re-encoding things in
 utf8, when in fact Buildbot expects to find unicode objects (that is, not
 in any encoding at all).  Try just running that script, and I expect your
 problems will melt away.

 Unicode is confusing :)

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1056#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list