[Buildbot-commits] [buildbot/buildbot] 8ef48f: use self.patch in tests, but not in <9.0.0 on py-2...

noreply at github.com noreply at github.com
Wed Dec 15 07:42:52 UTC 2010


Branch: refs/heads/master
Home:   https://github.com/buildbot/buildbot

Commit: 8ef48fca8952de8e7ecda398913723008b53d2a6
    https://github.com/buildbot/buildbot/commit/8ef48fca8952de8e7ecda398913723008b53d2a6
Author: Dustin J. Mitchell <dustin at mozilla.com>
Date:   2010-12-14 (Tue, 14 Dec 2010)

Changed paths:
  M master/buildbot/test/unit/test_changes_gitpoller.py
  M master/buildbot/util/monkeypatches.py
  M slave/buildslave/test/unit/test_bot_BuildSlave.py

Log Message:
-----------
use self.patch in tests, but not in <9.0.0 on py-2.7

The addCleanup method, which self.patch uses to clean up, does not work
correctly on py27.  This was handled in the slave monkeypatch, and is
now handled on the master, too.  This required some reworking of the
gitpoller tests, which are using an unqualified except (in the form of
an errback without f.trap) and thus eat the SkipTest exception.






More information about the Commits mailing list