[Buildbot-commits] [Buildbot] #1732: Gerrit: add support for non-GerritChangeSource triggers

[Buildbot]

#1732: Gerrit: add support for non-GerritChangeSource triggers
------------------------+---------------------------------------------------
Reporter:  PiotrSikora  |       Owner:                     
    Type:  enhancement  |      Status:  new                
Priority:  minor        |   Milestone:  0.8.+              
 Version:  0.8.2        |    Keywords:  gerrit, git, repovc
------------------------+---------------------------------------------------

Comment(by PiotrSikora):

 It seems that there are too many differences between how '''Git''' and
 '''Repo''' handle this to get away with one "universal" format.

 '''Gerrit + Git''' needs project, branch and "virtual branch", so we could
 either require:

 a) "gerrit_branch" or "event.patchSet.ref" property set to
 "refs/changes/61/61/2",

 b) "gerrit_change" property set to "61/2" and calculate
 "event.patchSet.ref ourselves.

 '''Gerrit + Repo''' needs (multiple) project, change and patchset id.
 Current implementation handles this with "d", "download", "download1",
 ..., "download9" properties and I think it's reasonable solution.

 '''GerritStatusPush''' is currently restricted to '''GerritChangeSource'''
 because it requires "event.patchSet.ref" property, but it's easily
 fixable.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/1732#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation