[Buildbot-commits] [Buildbot] #456: Slave's ShellCommand and msys are broken

[Buildbot]

#456: Slave's ShellCommand and msys are broken
--------------------+-------------------------------------------------------
Reporter:  even     |        Owner:  even    
    Type:  defect   |       Status:  reopened
Priority:  major    |    Milestone:  0.8.3   
 Version:  0.7.10   |   Resolution:          
Keywords:  windows  |  
--------------------+-------------------------------------------------------

Comment(by hushp1pt):

 Replying to [comment:9 dustin]:
 > I'm worried about playing whack-a-mole here, or getting too specific in
 analyzing the components of a buildstep.  Could we add a ShellCommand
 option that would be passed to the slave to enable this particular
 behavior?

 Thanks, I think that would be ideal. You could call the option
 with_cygwin_path.  If value == None, no change- same as regular Windows
 process.  If != None, skip the PWD reset in runprocess.py.

 For extra credit, if value looks like a Cygwin path string, then override
 the PATH that bash (or whatever) sees when it lands.  In the example
 http://buildbot.net/trac/wiki/CygwinShellCommands, I passed Cygwin's PATH
 through Shell Command's env['PATH'].  Implementing some kind of short cut
 for this override would be helpful, because env['PATH'] was the only value
 in env that had to be different between Windows and Linux builds,, and I
 had serious python and/or buildbot language troubles in my build factory,
 trying to define that env dictionary the right way at the right time. Your
 call. Thanks again.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/456#comment:10>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation