[Buildbot-commits] [Buildbot] #456: Slave's ShellCommand and msys are broken

Buildbot buildbot-devel at lists.sourceforge.net
Mon Dec 6 20:36:44 UTC 2010


#456: Slave's ShellCommand and msys are broken
-------------------+--------------------------------------------------------
Reporter:  even    |        Owner:  even    
    Type:  defect  |       Status:  reopened
Priority:  major   |    Milestone:  0.7.11  
 Version:  0.7.10  |   Resolution:          
Keywords:          |  
-------------------+--------------------------------------------------------

Comment(by hushp1pt):

 Replying to [comment:7 dustin]:
 > how can I identify a cygwin system in Python?

 I was wondering, in the earlier patch here, how did MACHTYPE know it was
 an MSYS system?
     self.environ.get('MACHTYPE', None) == 'i686-pc-msys'
 Do you need to start the buildslave from Msys for MACHTIME to say "msys"?
 If you started the buildslave from Cygwin, would MACHTYPE say "cygwin"?

 In fact, I do not start our Windows buildslave from Cygwin. I used the
 run-buildbot-as-service contrib. But I still want the BuildCommand
 commands to run under Cygwin.

 If you don't have MACHTYPE that says Cygwin, there probably is no
 foolproof way to tell if a ShellCommand buildstep wanted to run Cygwin.
 However, I bet if the first word of the first command in the build step
 was "bash", "bash.exe", or a full path to bash, and buildslave is Windows,
 then the odds would be pretty good that the command(s) were really meant
 for Cygwin bash- or for Msys bash.  Either way, the patch would help.

 Those who prefer to have their ShellCommand start a BAT file to run Cygwin
 commands, I guess they can still set PWD= before they call bash or
 whatever.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/456#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list