[Buildbot-commits] [Buildbot] #1702: The new slave disconnect timeout in BotMaster.getPerspective is too optimistic

Buildbot buildbot-devel at lists.sourceforge.net
Sat Dec 4 19:57:17 UTC 2010


#1702: The new slave disconnect timeout in BotMaster.getPerspective is too
optimistic
------------------------+---------------------------------------------------
Reporter:  exarkun      |        Owner:           
    Type:  enhancement  |       Status:  closed   
Priority:  major        |    Milestone:  undecided
 Version:  0.8.2        |   Resolution:  fixed    
Keywords:               |  
------------------------+---------------------------------------------------
Changes (by Dustin J. Mitchell):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 Delay new slaves until the old slave ping fails or succeeds

 When arbitrating a duplicate slave, ping the old slave (with a timeout)
 and let the new slave know that it is being delayed.  Then either reject
 the new slave with a Failure if the old slave is still alive, or allow
 the new slave to connect after the old slave has safely disconnected.
 Fixes #1702
  Changeset: 909d9af78688a841c2936408b4526997f0f25336

-- 
Ticket URL: <http://buildbot.net/trac/ticket/1702#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list