[Buildbot-commits] [Buildbot] #817: change manager ignores changeHorizon

[Buildbot]

#817: change manager ignores changeHorizon
---------------------+------------------------------------------------------
Reporter:  dustin    |        Owner:  catlee  
    Type:  defect    |       Status:  assigned
Priority:  major     |    Milestone:  0.8.2   
 Version:  0.8.0     |   Resolution:          
Keywords:  database  |  
---------------------+------------------------------------------------------

Comment(by catlee):

 First naive approach (just deleting changes older than changeHorizon)
 causes at least the web status to blow up:

 {{{
             data = self.content(request, ctx)
           File
 "/home/catlee/src/buildbot/master/buildbot/status/web/builder.py", line
 66, in content
             source = pb.getSourceStamp()
           File
 "/home/catlee/src/buildbot/master/buildbot/status/builder.py", line 751,
 in getSourceStamp
             br = self.db.getBuildRequestWithNumber(self.brid)
           File
 "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 762, in
 getBuildRequestWithNumber
             brid)
           File
 "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 212, in
 runInteractionNow
             return self._runInteractionNow(interaction, *args, **kwargs)
           File
 "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 237, in
 _runInteractionNow
             result = interaction(c, *args, **kwargs)
           File
 "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 776, in
 _txn_getBuildRequestWithNumber
             ss = self.getSourceStampNumberedNow(ssid, t)
           File
 "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 509, in
 getSourceStampNumberedNow
             ss = self._txn_getSourceStampNumbered(t, ssid)
           File
 "/home/catlee/src/buildbot/master/buildbot/db/connector.py", line 551, in
 _txn_getSourceStampNumbered
             ss = SourceStamp(branch, revision, patch, changes,
 project=project, repository=repository)
           File "/home/catlee/src/buildbot/master/buildbot/sourcestamp.py",
 line 54, in __init__
             self.branch = changes[-1].branch
         exceptions.AttributeError: 'NoneType' object has no attribute
 'branch'
 }}}

-- 
Ticket URL: <http://buildbot.net/trac/ticket/817#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation