[Buildbot-commits] [Buildbot] #729: use TCP keepalives (optionally) for slaves and IRC

[Buildbot]

#729: use TCP keepalives (optionally) for slaves and IRC
------------------------+---------------------------------------------------
Reporter:  dustin       |        Owner:  dustin
    Type:  enhancement  |       Status:  closed
Priority:  major        |    Milestone:  0.8.2 
 Version:  master       |   Resolution:  fixed 
Keywords:               |  
------------------------+---------------------------------------------------
Changes (by dustin):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 We do this already, although probably not the optimal way:
 {{{

 339     def gotPerspective(self, perspective):
 340         ReconnectingPBClientFactory.gotPerspective(self, perspective)
 341         self.perspective = perspective
 342         try:
 343             perspective.broker.transport.setTcpKeepAlive(1)
 344         except:
 345             log.msg("unable to set SO_KEEPALIVE")
 346             if not self.keepaliveInterval:
 347                 self.keepaliveInterval = 10*60
 }}}

 A patch for a more Twisted-compliant way to do this would be appreciated -
 I've never heard of protocol policies, and I don't know how I'd go about
 applying one.  Reopen the bug for such a purpose.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/729#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation