[Buildbot-commits] [Buildbot] #967: Buildmaster stops processing changes after receiving change from the future

[Buildbot]

#967: Buildmaster stops processing changes after receiving change from the future
------------------------+---------------------------------------------------
Reporter:  PiotrSikora  |       Owner:           
    Type:  defect       |      Status:  new      
Priority:  critical     |   Milestone:  undecided
 Version:  0.8.1        |    Keywords:           
------------------------+---------------------------------------------------
 When buildmaster receives change from the future (with when > now) then it
 stops processing new changes (even for different projects, with correct
 time). New changes don't even appear on the waterfall, so it looks like
 buildmaster would just hang.

 Patch below fixes this by correcting timestamp on changes from the future:
 {{{
 --- changes/changes.py.orig     Tue Aug  3 22:03:38 2010
 +++ changes/changes.py  Tue Aug 17 00:21:04 2010
 @@ -57,9 +57,11 @@
              return unicode(x)

          self.revision = none_or_unicode(revision)
 -        if when is None:
 -            when = util.now()
 -        self.when = when
 +        now = util.now()
 +        if when is None or when > now:
 +            self.when = now
 +        else:
 +            self.when = when
          self.branch = none_or_unicode(branch)
          self.category = none_or_unicode(category)
          self.revlink = revlink
 }}}

-- 
Ticket URL: <http://buildbot.net/trac/ticket/967>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation