[Buildbot-commits] [Buildbot] #959: Add 'native' CVS support
Buildbot
buildbot-devel at lists.sourceforge.net
Thu Aug 12 22:56:54 UTC 2010
#959: Add 'native' CVS support
------------------------+---------------------------------------------------
Reporter: AHowell | Owner: AHowell
Type: enhancement | Status: new
Priority: major | Milestone: 0.8.2
Version: master | Keywords: cvs
------------------------+---------------------------------------------------
Comment(by AHowell):
Maybe the approach take is to mark the existing CVS MailDirSources as
legacy in the docs and release notes, saying they may be removed in a
future release. If thats acceptable, I'll modify the docs.
I think my code is functionally complete for most needs. The two
attributes of a Change that it does not set are 'revlink' and
'properties'. 'revlink' does not doesn't make sense for CVS since it does
not have an id for a commit. I get around that by having a user supplied
function to map each file name, old CVS revision, new CVS revision to a
URL. Hmm, I should have called it 'urlmapper' instead of 'urlmaker'.
Perhaps I should add the 'properties' attribute, so they can be specified
as part of a BuildbotCVSMaildirSource. 'properties' in this case is a
dictionary, not a Properties class. That is the only tweak I can think of.
--
Ticket URL: <http://buildbot.net/trac/ticket/959#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the Commits
mailing list