[Buildbot-commits] [Buildbot] #958: Console: isRevisionEarlier assumes first and second are not None
Buildbot
buildbot-devel at lists.sourceforge.net
Tue Aug 10 16:29:40 UTC 2010
#958: Console: isRevisionEarlier assumes first and second are not None
-------------------+--------------------------------------------------------
Reporter: wms | Owner:
Type: defect | Status: new
Priority: major | Milestone: undecided
Version: 0.8.1 | Keywords: console
-------------------+--------------------------------------------------------
In {{{ status/web/console.py}}}, {{{
IntegerRevisionComparator::isRevisionEarlier() }}} assumes first and
second args are not None. Since it is possible to have builds with no
revision value, this function should probably guard against doing {{{
int(None) }}} which results in a TypeError exception.
--
Ticket URL: <http://buildbot.net/trac/ticket/958>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the Commits
mailing list