[Buildbot-commits] [SPAM] Re: [Buildbot] #946: BzrPoller Unhandled Error

[Buildbot]

#946: BzrPoller Unhandled Error
---------------------+------------------------------------------------------
Reporter:  Hbot      |       Owner:       
    Type:  defect    |      Status:  new  
Priority:  critical  |   Milestone:  0.8.2
 Version:  0.8.1     |    Keywords:  bzr  
---------------------+------------------------------------------------------
Changes (by dustin):

  * keywords:  BzrPoller => bzr


Old description:

> buildbot 0.8.1
> bzr_buildbot.py from git
> Python 2.7
> Bazaar (bzr) 2.2b4
> Debian GNU/Linux 5.0.3
>
> from bzr_buildbot import BzrPoller
> bzr_poller = BzrPoller(
>     url="lp:stellarium",
>     poll_interval=5*60,
> )
> c['change_source'] = [ bzr_poller ]
>
> 2010-07-31 16:34:44+0200 [-] adding 1 new changesources, removing 0
> 2010-07-31 16:34:44+0200 [-]
> BzrPoller(bzr+ssh://bazaar.launchpad.net/stellarium) starting
> 2010-07-31 16:34:44+0200 [-] Unhandled Error
>         Traceback (most recent call last):
>           File "/home/stellarium/lib/python2.7/buildbot/master.py", line
> 889, in <lambda>
>             d.addCallback(lambda res:
> self.loadConfig_Sources(change_sources))
>           File "/home/stellarium/lib/python2.7/buildbot/master.py", line
> 988, in loadConfig_Sources
>             d.addCallback(addNewOnes)
>           File
> "/home/stellarium/lib/python2.7/twisted/internet/defer.py", line 260, in
> addCallback
>             callbackKeywords=kw)
>           File
> "/home/stellarium/lib/python2.7/twisted/internet/defer.py", line 249, in
> addCallbacks
>             self._runCallbacks()
>         --- <exception caught here> ---
>           File
> "/home/stellarium/lib/python2.7/twisted/internet/defer.py", line 441, in
> _runCallbacks
>             self.result = callback(self.result, *args, **kw)
>           File "/home/stellarium/lib/python2.7/buildbot/master.py", line
> 986, in addNewOnes
>             [self.change_svc.addSource(s) for s in added_sources]
>           File
> "/home/stellarium/lib/python2.7/buildbot/changes/manager.py", line 91, in
> addSource
>             source.setServiceParent(self)
>           File
> "/home/stellarium/lib/python2.7/twisted/application/service.py", line
> 185, in setServiceParent
>             self.parent.addService(self)
>           File
> "/home/stellarium/lib/python2.7/twisted/application/service.py", line
> 305, in addService
>             service.startService()
>           File "/home/stellarium/buildmaster/bzr_buildbot.py", line 243,
> in startService
>             for change in reversed(self.parent.changes):
>         exceptions.AttributeError: ChangeManager instance has no
> attribute 'changes'

New description:

 buildbot 0.8.1
 bzr_buildbot.py from git
 Python 2.7
 Bazaar (bzr) 2.2b4
 Debian GNU/Linux 5.0.3

 {{{
 from bzr_buildbot import BzrPoller
 bzr_poller = BzrPoller(
     url="lp:stellarium",
     poll_interval=5*60,
 )
 c['change_source'] = [ bzr_poller ]
 }}}

 {{{
 2010-07-31 16:34:44+0200 [-] adding 1 new changesources, removing 0
 2010-07-31 16:34:44+0200 [-]
 BzrPoller(bzr+ssh://bazaar.launchpad.net/stellarium) starting
 2010-07-31 16:34:44+0200 [-] Unhandled Error
         Traceback (most recent call last):
           File "/home/stellarium/lib/python2.7/buildbot/master.py", line
 889, in <lambda>
             d.addCallback(lambda res:
 self.loadConfig_Sources(change_sources))
           File "/home/stellarium/lib/python2.7/buildbot/master.py", line
 988, in loadConfig_Sources
             d.addCallback(addNewOnes)
           File "/home/stellarium/lib/python2.7/twisted/internet/defer.py",
 line 260, in addCallback
             callbackKeywords=kw)
           File "/home/stellarium/lib/python2.7/twisted/internet/defer.py",
 line 249, in addCallbacks
             self._runCallbacks()
         --- <exception caught here> ---
           File "/home/stellarium/lib/python2.7/twisted/internet/defer.py",
 line 441, in _runCallbacks
             self.result = callback(self.result, *args, **kw)
           File "/home/stellarium/lib/python2.7/buildbot/master.py", line
 986, in addNewOnes
             [self.change_svc.addSource(s) for s in added_sources]
           File
 "/home/stellarium/lib/python2.7/buildbot/changes/manager.py", line 91, in
 addSource
             source.setServiceParent(self)
           File
 "/home/stellarium/lib/python2.7/twisted/application/service.py", line 185,
 in setServiceParent
             self.parent.addService(self)
           File
 "/home/stellarium/lib/python2.7/twisted/application/service.py", line 305,
 in addService
             service.startService()
           File "/home/stellarium/buildmaster/bzr_buildbot.py", line 243,
 in startService
             for change in reversed(self.parent.changes):
         exceptions.AttributeError: ChangeManager instance has no attribute
 'changes'
 }}}

--

Comment:

 Looks like the bzr_buildbot.py needs to get updated to work with the new
 schedulerdb stuff - changes are no longer available as a simple list.
 While we're at it, it should get merged into Buildbot proper.  And tested.
 And documented.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/946#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation