[Buildbot-commits] [SPAM] [Buildbot] #803: Disable patch output in twistd.log

Buildbot buildbot-devel at lists.sourceforge.net
Fri Apr 23 15:45:11 UTC 2010


#803: Disable patch output in twistd.log
------------------------+---------------------------------------------------
Reporter:  maruel       |       Owner:           
    Type:  enhancement  |      Status:  new      
Priority:  minor        |   Milestone:  undecided
 Version:  master       |    Keywords:           
------------------------+---------------------------------------------------
 This ticket is about changing the functionality of
 buildbot.process.buildstep.LoggingBuildStep.startCommand() to not log the
 actual patch even if present. It will simply logs its length instead. Only
 relevant to buildbot try/try server.

 I'm not a fan of making it optional, it just adds yet another untested
 code path.

 See http://codereview.chromium.org/1759006 as an implementation.

 Another possible implementation would be to change the patch argument to
 be an object, make it act like a tuple and change its __repr__. I think
 it's overkill.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/803>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list