[Buildbot-commits] [djmitche/buildbot] 673369: status.words.py: Make Contact a proper IStatusRece...

[noreply at github.com]

Branch: refs/heads/master
Home:   http://github.com/djmitche/buildbot

Commit: 673369b830534d84d3e0708970c52bb72a124d81
    http://github.com/djmitche/buildbot/commit/673369b830534d84d3e0708970c52bb72a124d81
Author: Jay Soffian <jaysoffian at gmail.com>
Date:   2010-04-08 (Thu, 08 Apr 2010)

Changed paths:
  M buildbot/status/words.py
  M docs/developer.texinfo

Log Message:
-----------
status.words.py: Make Contact a proper IStatusReceiver

Since Contact is an IStatusReceiver, it (and its subclasses) should
declare that they implement IStatusReceiver. As well, make Contact
inherit from base.StatusReceiver so that the unimplemented
IStatusReceiver methods do not need to be stubbed out.

Add a note to developer.texinfo saying that this pattern should[*] be
followed for all IStatusReceivers.

[*] "should" instead of "must" as of 9c2bf24 (make notifications a bit
more resilient to missing methods, 2010-02-13) and c79f09b (check for
notification methods before calling them, 2010-02-15)


Commit: 69f3a0ecdf354242ca089a5e26e31d47a65abb76
    http://github.com/djmitche/buildbot/commit/69f3a0ecdf354242ca089a5e26e31d47a65abb76
Author: Dustin J. Mitchell <dustin at zmanda.com>
Date:   2010-04-08 (Thu, 08 Apr 2010)

Changed paths:
  M buildbot/status/words.py
  M docs/developer.texinfo

Log Message:
-----------
Merge branch 'master' of git://github.com/jaysoffian/buildbot

* 'master' of git://github.com/jaysoffian/buildbot:
  status.words.py: Make Contact a proper IStatusReceiver

Signed-off-by: Dustin J. Mitchell <dustin at zmanda.com>