[Buildbot-commits] [SPAM] [Buildbot] #774: Commit message not shown in change page

[Buildbot]

#774: Commit message not shown in change page
--------------------+-------------------------------------------------------
Reporter:  Nicolas  |       Owner:             
    Type:  defect   |      Status:  new        
Priority:  minor    |   Milestone:  0.8.0      
 Version:  master   |    Keywords:  jinja patch
--------------------+-------------------------------------------------------
 If the `changecommentlink` feature is ''not'' in use, pages like
 `/changes/123` in the webstatus don't show the commit message.

 From the code, it looks like it will show the change's ‘project’ instead
 (wow, since when do `Change`s have a `project` property?). This is because
 the lambda for the “no `changelink` given” case has its arguments swapped.

 {{{
 #!diff
 diff --git a/buildbot/status/web/base.py b/buildbot/status/web/base.py
 index 677b646..e02252f 100644
 --- a/buildbot/status/web/base.py
 +++ b/buildbot/status/web/base.py
 @@ -602,7 +602,7 @@ def changelinkfilter(changelink):
          return filter

      if not changelink:
 -        return lambda project, text: jinja2.escape(text)
 +        return lambda text, project: jinja2.escape(text)

      elif isinstance(changelink, dict):
          def dict_filter(text, project):
 }}}

-- 
Ticket URL: <http://buildbot.net/trac/ticket/774>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation