[Buildbot-commits] [djmitche/buildbot] 3cfc46: Removed unused import

[noreply at github.com]

Branch: refs/heads/master
Home:   http://github.com/djmitche/buildbot

Commit: 3cfc460d40dca32cac2dac168cc51e9751da81a2
    http://github.com/djmitche/buildbot/commit/3cfc460d40dca32cac2dac168cc51e9751da81a2
Author: Aviv Ben-Yosef <aviv.by at gmail.com>
Date:   2009-12-22 (Tue, 22 Dec 2009)

Changed paths:
  M buildbot/test/test_console.py

Log Message:
-----------
Removed unused import


Commit: 5264eda6284dcc8209f8e00a40b9698643bcfc47
    http://github.com/djmitche/buildbot/commit/5264eda6284dcc8209f8e00a40b9698643bcfc47
Author: Aviv Ben-Yosef <aviv.by at gmail.com>
Date:   2009-12-22 (Tue, 22 Dec 2009)

Changed paths:
  M buildbot/status/web/console.py

Log Message:
-----------
removing unused imports


Commit: 2835d4c7a33c4f1d47f9f5f5025b822ca5bee65c
    http://github.com/djmitche/buildbot/commit/2835d4c7a33c4f1d47f9f5f5025b822ca5bee65c
Author: Aviv Ben-Yosef <aviv.by at gmail.com>
Date:   2009-12-22 (Tue, 22 Dec 2009)

Changed paths:
  M buildbot/status/web/console.py
  M buildbot/test/test_console.py

Log Message:
-----------
adding comparators


Commit: 98f39c12bb8cf60b7e003c2effc9a47def2c2645
    http://github.com/djmitche/buildbot/commit/98f39c12bb8cf60b7e003c2effc9a47def2c2645
Author: Aviv Ben-Yosef <aviv.by at gmail.com>
Date:   2009-12-22 (Tue, 22 Dec 2009)

Changed paths:
  M buildbot/status/web/console.py

Log Message:
-----------
Removing useless conversion to int

This simple comparison between revisions uses a conversion to int that breaks if the revision is not an int (like in Git). There's no difference simply comparing the strings directly, so I removed this.


Commit: 4824989af1a9786c959c3f986733999d68535e19
    http://github.com/djmitche/buildbot/commit/4824989af1a9786c959c3f986733999d68535e19
Author: Aviv Ben-Yosef <aviv.by at gmail.com>
Date:   2009-12-22 (Tue, 22 Dec 2009)

Changed paths:
  M buildbot/status/web/console.py
  M buildbot/test/test_console.py

Log Message:
-----------
Removing useless methods

At first, I saw that the changes list was being sorted by the revisions, and thought that because of that
it will be necessary to allow sorting by time for the other VCSs. But, then I realized that the sorting
was being done simply so that duplicate changes with same revision will be grouped for removing. This works
no matter if the revision is a number or not.


Commit: 6fba2d38e1a8d86914d694f400227c191e8116f2
    http://github.com/djmitche/buildbot/commit/6fba2d38e1a8d86914d694f400227c191e8116f2
Author: Aviv Ben-Yosef <aviv.by at gmail.com>
Date:   2009-12-22 (Tue, 22 Dec 2009)

Changed paths:
  M buildbot/status/web/console.py
  M buildbot/test/test_console.py

Log Message:
-----------
Adding ability to validate revisions


Commit: 83a1c283cf17793f816aab1e2af1f75dc4ea4356
    http://github.com/djmitche/buildbot/commit/83a1c283cf17793f816aab1e2af1f75dc4ea4356
Author: Aviv Ben-Yosef <aviv.by at gmail.com>
Date:   2009-12-22 (Tue, 22 Dec 2009)

Changed paths:
  M buildbot/status/web/console.py

Log Message:
-----------
Using the created classes


Commit: 939588b066b0b30dc52f0417196a35f07446b47b
    http://github.com/djmitche/buildbot/commit/939588b066b0b30dc52f0417196a35f07446b47b
Author: Aviv Ben-Yosef <aviv.by at gmail.com>
Date:   2009-12-22 (Tue, 22 Dec 2009)

Changed paths:
  M buildbot/status/web/console.py
  M buildbot/test/test_console.py

Log Message:
-----------
Apparantly this is needed


Commit: 6c5ae79608a6db370a07cb44f7ca66bd4e4679b9
    http://github.com/djmitche/buildbot/commit/6c5ae79608a6db370a07cb44f7ca66bd4e4679b9
Author: Aviv Ben-Yosef <aviv.by at gmail.com>
Date:   2009-12-22 (Tue, 22 Dec 2009)

Changed paths:
  M buildbot/status/web/baseweb.py
  M buildbot/status/web/console.py

Log Message:
-----------
Adding flag for choosing ordering scheme


Commit: a4b19bb3e96e14c32b446617faf3da306a3deaef
    http://github.com/djmitche/buildbot/commit/a4b19bb3e96e14c32b446617faf3da306a3deaef
Author: Aviv Ben-Yosef <aviv.by at gmail.com>
Date:   2009-12-22 (Tue, 22 Dec 2009)

Changed paths:
  M buildbot/status/web/console.py

Log Message:
-----------
Removing the comment that is no longer true