[Buildbot-commits] buildbot/buildbot/process base.py,1.83,1.84

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot/process
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv17705/buildbot/process

Modified Files:
	base.py 
Log Message:
[project @ #124:remove-custom-props.patch]
Remove custom properties, which are now largely redundant, and on which the
properties interface was modeled.

Original author: dustin at v.igoro.us
Date: 2008-04-13 19:55:26+00:00

Index: base.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/process/base.py,v
retrieving revision 1.83
retrieving revision 1.84
diff -u -d -r1.83 -r1.84
--- base.py	22 May 2008 22:13:11 -0000	1.83
+++ base.py	22 May 2008 22:13:22 -0000	1.84
@@ -53,11 +53,10 @@
     source = None
     builder = None
     startCount = 0 # how many times we have tried to start this build
-    custom_props = {}
 
     implements(interfaces.IBuildRequestControl)
 
-    def __init__(self, reason, source, builderName=None, custom_props=None, properties=None):
+    def __init__(self, reason, source, builderName=None, properties=None):
         # TODO: remove the =None on builderName, it is there so I don't have
         # to change a lot of tests that create BuildRequest objects
         assert interfaces.ISourceStamp(source, None)
@@ -67,8 +66,6 @@
         self.properties = Properties()
         if properties:
             self.properties.updateFromProperties(properties)
-        if custom_props:
-            self.properties.update(custom_props, "BuildRequest-custom_props")
 
         self.start_watchers = []
         self.finish_watchers = []
@@ -96,9 +93,6 @@
         self.finish_watchers.append(d)
         return d
 
-    def customProps(self):
-     return self.custom_props
-
     # these are called by the Builder
 
     def requestSubmitted(self, builder):