[Buildbot-commits] buildbot/buildbot/changes svnpoller.py,1.6,1.7

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot/changes
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv26583/buildbot/changes

Modified Files:
	svnpoller.py 
Log Message:
[project @ #58:svnpoller-revision-int.patch]
Patch from Dan Locks <dwlocks>: MailNotifier assumes that revision
is a string, but SvnPoller provided an int.

Original author: dustin at v.igoro.us
Date: 2008-03-23 21:08:10+00:00

Index: svnpoller.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/changes/svnpoller.py,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -d -r1.6 -r1.7
--- svnpoller.py	17 Jun 2007 21:10:39 -0000	1.6
+++ svnpoller.py	30 Mar 2008 01:29:51 -0000	1.7
@@ -385,10 +385,7 @@
 
         for el in new_logentries:
             branch_files = [] # get oldest change first
-            # TODO: revisit this, I think I've settled on Change.revision
-            # being a string everywhere, and leaving the interpretation
-            # of that string up to b.s.source.SVN methods
-            revision = int(el.getAttribute("revision"))
+            revision = str(el.getAttribute("revision"))
             dbgMsg("Adding change revision %s" % (revision,))
             # TODO: the rest of buildbot may not be ready for unicode 'who'
             # values