[Buildbot-commits] buildbot ChangeLog,1.1047,1.1048

Brian Warner warner at users.sourceforge.net
Sun Mar 23 03:14:49 UTC 2008


Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv3555

Modified Files:
	ChangeLog 
Log Message:
[project @ builder: make it possible to stop builds after a Builder-changing reconfig. Closes #22.]

Original author: warner at lothar.com
Date: 2008-03-23 03:11:09+00:00

Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.1047
retrieving revision 1.1048
diff -u -d -r1.1047 -r1.1048
--- ChangeLog	23 Mar 2008 00:36:56 -0000	1.1047
+++ ChangeLog	23 Mar 2008 03:14:46 -0000	1.1048
@@ -1,5 +1,15 @@
 2008-03-22  Brian Warner  <warner at lothar.com>
 
+	* buildbot/process/builder.py (Builder): use self.old_building to
+	track Builds from a previous version of this Builder and are still
+	running. This makes it possible for IBuilderControl to get at
+	them, allowing the "Stop Build" button to work after a
+	Builder-replacing reconfig. Closes #22.
+	(Builder.consumeTheSoulOfYourPredecessor): grab weakrefs from the
+	old Builder's self.building attribute, instead of strongrefs,
+	since there's no good place to explicitly forget about them.
+	(Builder.getBuild): factor this out of BuilderControl
+
 	* buildbot/process/buildstep.py (LogLineObserver.setMaxLineLength):
 	new method to override the default 16KiB line length. Lines that
 	are longer than this will cause the rest of the log file to be





More information about the Commits mailing list