[Buildbot-commits] buildbot ChangeLog,1.1013,1.1014

[Brian Warner]

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv28197

Modified Files:
	ChangeLog 
Log Message:
[project @ file transfer: avoid tail recursion, to fix stack-depth errors. Closes #106.]

Original author: warner at lothar.com
Date: 2008-01-01 02:44:42+00:00

Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.1013
retrieving revision 1.1014
diff -u -d -r1.1013 -r1.1014
--- ChangeLog	23 Dec 2007 08:35:31 -0000	1.1013
+++ ChangeLog	1 Jan 2008 02:46:37 -0000	1.1014
@@ -1,3 +1,15 @@
+2007-12-31  Brian Warner  <warner at lothar.com>
+
+	* buildbot/slave/commands.py (SlaveFileUploadCommand.start):
+	rewrite the main loop to avoid tail recursion, since Deferreds
+	don't optimize those out. Without this, at the end of the transfer
+	we'd hit a stack depth of about two or three frames per block
+	transferred, and for large transfers this would run into a "stack
+	depth exceeded" error. Closes #106.
+	(SlaveFileDownloadCommand.start): same, for downloads.
+	* buildbot/test/test_transfer.py (Upload.testLotsOfBlocks): test it
+	(Download.testLotsOfBlocks): same
+
 2007-12-22  Brian Warner  <warner at lothar.com>
 
 	* buildbot/steps/shell.py (TreeSize): This never worked properly.