From warner at users.sourceforge.net  Tue Feb  5 21:05:36 2008
From: warner at users.sourceforge.net (Brian Warner)
Date: Tue, 05 Feb 2008 21:05:36 +0000
Subject: [Buildbot-commits] buildbot/buildbot/test test_slaves.py, 1.15, 1.16
Message-ID: <E1JMUz3-0005Ut-CS@mail.sourceforge.net>

Update of /cvsroot/buildbot/buildbot/buildbot/test
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv9857/buildbot/test

Modified Files:
	test_slaves.py 
Log Message:
[project @ BuildSlave.notify_on_missing= add To: header]

Original author: warner at lothar.com
Date: 2008-02-05 20:58:24+00:00

Index: test_slaves.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/test/test_slaves.py,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -d -r1.15 -r1.16
--- test_slaves.py	29 Sep 2007 01:07:56 -0000	1.15
+++ test_slaves.py	5 Feb 2008 21:05:34 -0000	1.16
@@ -516,6 +516,7 @@
             msg,recips = fm.messages[0]
             self.failUnlessEqual(recips, ["admin"])
             body = msg.as_string()
+            self.failUnlessIn("To: admin", body)
             self.failUnlessIn("Subject: Buildbot: buildslave bot1 was lost",
                               body)
             self.failUnlessIn("From: buildbot at example.org", body)




From warner at users.sourceforge.net  Tue Feb  5 21:05:36 2008
From: warner at users.sourceforge.net (Brian Warner)
Date: Tue, 05 Feb 2008 21:05:36 +0000
Subject: [Buildbot-commits] buildbot ChangeLog,1.1016,1.1017
Message-ID: <E1JMUz3-0007rJ-CM@mail.sourceforge.net>

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv9857

Modified Files:
	ChangeLog 
Log Message:
[project @ BuildSlave.notify_on_missing= add To: header]

Original author: warner at lothar.com
Date: 2008-02-05 20:58:24+00:00

Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.1016
retrieving revision 1.1017
diff -u -d -r1.1016 -r1.1017
--- ChangeLog	1 Jan 2008 03:27:37 -0000	1.1016
+++ ChangeLog	5 Feb 2008 21:05:34 -0000	1.1017
@@ -1,3 +1,11 @@
+2008-02-05  Brian Warner  <warner at lothar.com>
+
+	* buildbot/buildslave.py (BuildSlave._missing_timer_fired): add a
+	To: header to the email message we're composing. Oops. Thanks
+	to Zandr Milewski for the catch.
+	* buildbot/test/test_slaves.py (BuildSlave.test_mail_on_missing):
+	test for it
+
 2007-12-31  Brian Warner  <warner at lothar.com>
 
 	* buildbot/test/test_transfer.py (Upload.testLotsOfBlocks): remove




From warner at users.sourceforge.net  Tue Feb  5 21:05:36 2008
From: warner at users.sourceforge.net (Brian Warner)
Date: Tue, 05 Feb 2008 21:05:36 +0000
Subject: [Buildbot-commits] buildbot/buildbot buildslave.py,1.8,1.9
Message-ID: <E1JMUz3-0005Up-Bu@mail.sourceforge.net>

Update of /cvsroot/buildbot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv9857/buildbot

Modified Files:
	buildslave.py 
Log Message:
[project @ BuildSlave.notify_on_missing= add To: header]

Original author: warner at lothar.com
Date: 2008-02-05 20:58:24+00:00

Index: buildslave.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/buildslave.py,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -d -r1.8 -r1.9
--- buildslave.py	29 Sep 2007 01:07:49 -0000	1.8
+++ buildslave.py	5 Feb 2008 21:05:34 -0000	1.9
@@ -222,6 +222,7 @@
         m['Subject'] = "Buildbot: buildslave %s was lost" % self.slavename
         m['From'] = st.fromaddr
         recipients = self.notify_on_missing
+        m['To'] = ", ".join(recipients)
         d = st.sendMessage(m, recipients)
         # return the Deferred for testing purposes
         return d