[Buildbot-commits] buildbot ChangeLog,1.860,1.861

Brian Warner warner at users.sourceforge.net
Tue Jul 3 02:22:21 UTC 2007


Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv30105

Modified Files:
	ChangeLog 
Log Message:
[project @ test_slaves.py: fix an intermittent failure, disappeared slaves were reconnecting]

Original author: warner at lothar.com
Date: 2007-07-03 02:21:43+00:00

Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.860
retrieving revision 1.861
diff -u -d -r1.860 -r1.861
--- ChangeLog	2 Jul 2007 17:50:16 -0000	1.860
+++ ChangeLog	3 Jul 2007 02:22:18 -0000	1.861
@@ -1,5 +1,16 @@
 2007-07-02  Brian Warner  <warner at lothar.com>
 
+	* buildbot/test/runutils.py (RunMixin.disappearSlave): once a
+	slave has been disappeared, don't let it reconnect. This was
+	causing an intermittent failure in test_slaves.py, when the slave
+	that was supposed to be gone managed to come back by the end of
+	the test and affect the count.
+	* buildbot/test/test_slaves.py (Slave.testFallback2): minor
+	refactorings
+	* buildbot/process/builder.py (SlaveBuilder.__repr__): added some
+	diagnostic messages to track down this problem
+	(Builder.startBuild): same
+
 	* buildbot/process/builder.py (Builder.maybeStartBuild): choose
 	the slave randomly rather than always taking the first one. Thanks
 	to Pike for the patch. Closes #36.





More information about the Commits mailing list