[Buildbot-commits] buildbot/buildbot master.py,1.104,1.105

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv13515/buildbot

Modified Files:
	master.py 
Log Message:
[project @ master.py: warn about orphan Builders: those which have no Schedulers to drive them]

Original author: warner at lothar.com
Date: 2007-02-07 03:38:48

Index: master.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/master.py,v
retrieving revision 1.104
retrieving revision 1.105
diff -u -d -r1.104 -r1.105
--- master.py	7 Feb 2007 03:42:34 -0000	1.104
+++ master.py	7 Feb 2007 03:42:41 -0000	1.105
@@ -721,11 +721,15 @@
                                  % (b['name'], b['builddir']))
             dirnames.append(b['builddir'])
 
+        unscheduled_buildernames = buildernames[:]
         schedulernames = []
         for s in schedulers:
             for b in s.listBuilderNames():
                 assert b in buildernames, \
                        "%s uses unknown builder %s" % (s, b)
+                if b in unscheduled_buildernames:
+                    unscheduled_buildernames.remove(b)
+
             if s.name in schedulernames:
                 # TODO: schedulers share a namespace with other Service
                 # children of the BuildMaster node, like status plugins, the
@@ -736,6 +740,10 @@
                 raise ValueError(msg)
             schedulernames.append(s.name)
 
+        if unscheduled_buildernames:
+            log.msg("Warning: some Builders have no Schedulers to drive them:"
+                    " %s" % (unscheduled_buildernames,))
+
         # assert that all locks used by the Builds and their Steps are
         # uniquely named.
         locks = {}