[Buildbot-commits] buildbot ChangeLog,1.1008,1.1009

Brian Warner warner at users.sourceforge.net
Sat Dec 22 06:28:07 UTC 2007


Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv30070

Modified Files:
	ChangeLog 
Log Message:
[project @ logwatcher: use /usr/bin/tail instead of our hand-rolled version, to make it work on OS-X. Closes #141.]

Original author: warner at lothar.com
Date: 2007-12-22 06:26:04+00:00

Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.1008
retrieving revision 1.1009
diff -u -d -r1.1008 -r1.1009
--- ChangeLog	15 Dec 2007 01:02:01 -0000	1.1008
+++ ChangeLog	22 Dec 2007 06:28:05 -0000	1.1009
@@ -1,3 +1,13 @@
+2007-12-21  Brian Warner  <warner at lothar.com>
+
+	* buildbot/scripts/logwatcher.py (LogWatcher.start): rewrite to
+	spawn /usr/bin/tail to follow the target's twistd.log . It turns
+	out that OS-X file EOF semantics are different, and the naive
+	read-then-read-again approach I was using doesn't work (the first
+	EOF we hit is sticky). tail gets it right, so rely upon it instead
+	of reimplementing the wheel. This should make 'buildbot start'
+	correctly follow the logfile on OS-X, thus closing #141.
+
 2007-12-14  Brian Warner  <warner at lothar.com>
 
 	* buildbot/steps/shell.py (ShellCommand.__init__): stash the





More information about the Commits mailing list