[Buildbot-commits] buildbot ChangeLog,1.916,1.917
Brian Warner
warner at users.sourceforge.net
Sun Aug 12 23:17:14 UTC 2007
Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv27314
Modified Files:
ChangeLog
Log Message:
[project @ make BuildSlaves live as Service children of the BotMaster]
Original author: warner at lothar.com
Date: 2007-08-12 23:14:33+00:00
Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.916
retrieving revision 1.917
diff -u -d -r1.916 -r1.917
--- ChangeLog 12 Aug 2007 22:23:07 -0000 1.916
+++ ChangeLog 12 Aug 2007 23:17:12 -0000 1.917
@@ -1,5 +1,22 @@
2007-08-12 Brian Warner <warner at lothar.com>
+ * buildbot/buildslave.py (BuildSlave): these are now MultiService
+ instances too, and live as children of the BotMaster. The main
+ advantage of this approach is that BuildSlaves can know when they
+ are being removed (so they can shut off the upcoming
+ when-do-we-email-an-admin-because-we-lost-our-slave timer).
+ * buildbot/interfaces.py (IBuildSlave): marker interface so we can
+ identify which service children are BuildSlaves
+ * buildbot/master.py (BuildMaster.loadConfig_Slaves): handle the
+ Checker updates here, but delegate the rest to..
+ (BotMaster.loadConfig_Slaves): .. here, which looks at the
+ BotMaster's service children to identify the old slaves. I think
+ the previous approach of using master.slaves was broken in the
+ face of config updates that modified BuildSlave instances but did
+ not completely replace them.
+ * docs/buildbot.texinfo (Developer's Appendix): note the change to
+ the Service hierarchy
+
* buildbot/status/web/slaves.py (BuildSlavesResource): new status
page (at URL /buildslaves/) to view status of all buildslaves at
once, including how long it's been since we last heard from them,
More information about the Commits
mailing list