[Buildbot-commits] buildbot/buildbot/process factory.py,1.16,1.17
Brian Warner
warner at users.sourceforge.net
Sun Aug 12 07:43:57 UTC 2007
Update of /cvsroot/buildbot/buildbot/buildbot/process
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv28043/buildbot/process
Modified Files:
factory.py
Log Message:
[project @ factory.py: allow BuildFactory subclasses to accept a BuildStep instance as the 'source' argument]
Original author: warner at lothar.com
Date: 2007-08-12 07:30:29+00:00
Index: factory.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/process/factory.py,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -d -r1.16 -r1.17
--- factory.py 18 Jun 2007 02:52:49 -0000 1.16
+++ factory.py 12 Aug 2007 07:43:55 -0000 1.17
@@ -56,8 +56,6 @@
configureFlags=[],
compile=["make", "all"],
test=["make", "check"]):
- assert isinstance(source, tuple)
- assert issubclass(source[0], BuildStep)
BuildFactory.__init__(self, [source])
if configure is not None:
# we either need to wind up with a string (which will be
@@ -80,8 +78,6 @@
class CPAN(BuildFactory):
def __init__(self, source, perl="perl"):
- assert isinstance(source, tuple)
- assert issubclass(source[0], BuildStep)
BuildFactory.__init__(self, [source])
self.addStep(Configure, command=[perl, "Makefile.PL"])
self.addStep(Compile, command=["make"])
@@ -89,8 +85,6 @@
class Distutils(BuildFactory):
def __init__(self, source, python="python", test=None):
- assert isinstance(source, tuple)
- assert issubclass(source[0], BuildStep)
BuildFactory.__init__(self, [source])
self.addStep(Compile, command=[python, "./setup.py", "build"])
if test is not None:
@@ -116,8 +110,6 @@
testpath=".", randomly=None, recurse=None,
tests=None, useTestCaseNames=False, env=None):
BuildFactory.__init__(self, [source])
- assert isinstance(source, tuple)
- assert issubclass(source[0], BuildStep)
assert tests or useTestCaseNames, "must use one or the other"
if trial is not None:
self.trial = trial
More information about the Commits
mailing list