[Buildbot-commits] buildbot ChangeLog,1.755,1.756

[Brian Warner]

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv29161

Modified Files:
	ChangeLog 
Log Message:
[project @ LogFileWatcher: explicitly close the filehandle to fix SF#1568415]

Original author: warner at lothar.com
Date: 2006-09-30 19:32:09

Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.755
retrieving revision 1.756
diff -u -d -r1.755 -r1.756
--- ChangeLog	29 Sep 2006 07:04:20 -0000	1.755
+++ ChangeLog	30 Sep 2006 19:32:48 -0000	1.756
@@ -1,3 +1,14 @@
+2006-09-30  Brian Warner  <warner at lothar.com>
+
+	* buildbot/slave/commands.py (LogFileWatcher.stop): explicitly
+	close the filehandle when we stop watching the file. Before, the
+	filehandle was only closed when the LogFileWatcher was
+	garbage-collected, which could be quite a while in the future. If
+	it was still open by the time the next build started, windows will
+	refuse to let the new build delete the old build/ directory. Fixes
+	SF#1568415, thanks to <scmikes>, <FireMoth>, and <radix> on
+	#twisted for the catch.
+
 2006-09-29  Brian Warner  <warner at lothar.com>
 
 	* buildbot/status/tinderbox.py (TinderboxMailNotifier): updates