[Buildbot-commits] buildbot/buildbot/steps shell.py,1.3,1.4

Brian Warner warner at users.sourceforge.net
Sun Nov 26 08:31:39 UTC 2006


Update of /cvsroot/buildbot/buildbot/buildbot/steps
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv30968/buildbot/steps

Modified Files:
	shell.py 
Log Message:
[project @ ShellCommand: you can't use command=WithProperties(stuff): improve docs and add an assertion]

Original author: warner at lothar.com
Date: 2006-11-26 08:30:59

Index: shell.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/steps/shell.py,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- shell.py	17 Sep 2006 20:35:49 -0000	1.3
+++ shell.py	26 Nov 2006 08:31:37 -0000	1.4
@@ -203,6 +203,7 @@
         # to set up an argv array, an environment, or extra logfiles= (like
         # the Source subclasses) can just skip straight to startCommand()
         command = self._interpolateProperties(self.command)
+        assert isinstance(command, (list, tuple, str))
         # create the actual RemoteShellCommand instance now
         kwargs = self.remote_kwargs
         kwargs['command'] = command





More information about the Commits mailing list