[Buildbot-commits] buildbot/buildbot/process base.py,1.63,1.64

[Brian Warner]

Update of /cvsroot/buildbot/buildbot/buildbot/process
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv26989/buildbot/process

Modified Files:
	base.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-532
Creator:  Brian Warner <warner at lothar.com>

Try_Jobdir: windows fix, add logging to Build.setupBuild

	* buildbot/scheduler.py (Try_Jobdir.messageReceived): when
	operating under windows, move the file before opening it, since
	you can't rename a file that somebody has open.

	* buildbot/process/base.py (Build.setupBuild): if something goes
	wrong while creating a Step, log the name and arguments, since the
	error message when you get the number of arguments wrong is really
	opaque.


Index: base.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/process/base.py,v
retrieving revision 1.63
retrieving revision 1.64
diff -u -d -r1.63 -r1.64
--- base.py	24 Apr 2006 06:45:36 -0000	1.63
+++ base.py	7 May 2006 18:36:40 -0000	1.64
@@ -351,7 +351,12 @@
             args = args.copy()
             if not args.has_key("workdir"):
                 args['workdir'] = self.workdir
-            step = factory(build=self, **args)
+            try:
+                step = factory(build=self, **args)
+            except:
+                log.msg("error while creating step, factory=%s, args=%s"
+                        % (factory, args))
+                raise
             name = step.name
             count = 1
             while name in stepnames and count < 100: