[Buildbot-commits] buildbot ChangeLog,1.669,1.670

[Brian Warner]

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv14596

Modified Files:
	ChangeLog 
Log Message:
[project @ slave: refactor Command startup/completion a bit]

Original author: warner at lothar.com
Date: 2006-06-20 03:55:56

Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.669
retrieving revision 1.670
diff -u -d -r1.669 -r1.670
--- ChangeLog	20 Jun 2006 08:08:39 -0000	1.669
+++ ChangeLog	20 Jun 2006 08:08:45 -0000	1.670
@@ -1,3 +1,19 @@
+2006-06-19  Brian Warner  <warner at lothar.com>
+
+	* buildbot/slave/commands.py (Command.doStart): refactor Command
+	startup/completion a bit: now the SlaveBuilder calls doStart(),
+	which is not meant for overridding by subclasses, and doStart()
+	calls start(), which is. Likewise the SlaveBuilder calls
+	doInterrupt(), and subclasses override interrupt(). This also puts
+	responsibility for maintaining .running in Command rather than in
+	SlaveBuilder.
+	(Command.doInterrupt): same
+	(Command.commandComplete): same, this is called when the deferred
+	returned by start() completes.
+	* buildbot/slave/bot.py (SlaveBuilder.remote_startCommand): same
+	(SlaveBuilder.remote_interruptCommand): same
+	(SlaveBuilder.stopCommand): same
+
 2006-06-16  Brian Warner  <warner at lothar.com>
 
 	* buildbot/test/test_shell.py: new test file to contain everything