[Buildbot-commits] buildbot ChangeLog,1.652,1.653

[Brian Warner]

Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv16095

Modified Files:
	ChangeLog 
Log Message:
[project @ test_p4poller: fix python2.2 compatibility]

Original author: warner at lothar.com
Date: 2006-06-14 06:47:51

Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.652
retrieving revision 1.653
diff -u -d -r1.652 -r1.653
--- ChangeLog	12 Jun 2006 08:36:38 -0000	1.652
+++ ChangeLog	14 Jun 2006 06:49:19 -0000	1.653
@@ -1,3 +1,17 @@
+2006-06-13  Brian Warner  <warner at lothar.com>
+
+	* buildbot/test/test_p4poller.py (TestP4Poller.failUnlessIn): fix
+	compatibility with python2.2, which doesn't have the 'substr in
+	str' feature.
+	(TestP4Poller.makeTime): utility function to construct the
+	timestamp using the same strptime() approach as p4poller does. It
+	turns out that time.mktime() behaves slightly differently under
+	python2.2, probably something to do with the DST flag, and that
+	causes the test to fail under python2.2. (changing the mktime()
+	arguments to have dst=0 instead of -1 caused it to fail under
+	python2.3. Go figure.)
+	(TestP4Poller._testCheck3): use our makeTime() instead of mktime()
+
 2006-06-12  Brian Warner  <warner at lothar.com>
 
 	* buildbot/process/step.py (P4): merge in patch SF#1473939, adding