From warner at users.sourceforge.net Fri Jun 2 03:32:25 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Fri, 02 Jun 2006 03:32:25 +0000
Subject: [Buildbot-commits] buildbot/buildbot/process step.py,1.86,1.87
Message-ID:
Update of /cvsroot/buildbot/buildbot/buildbot/process
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv4681/buildbot/process
Modified Files:
step.py
Log Message:
[project @ set ShellCommand.flunkOnFailure=True by default]
Original author: warner at lothar.com
Date: 2006-06-02 03:23:23
Index: step.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/process/step.py,v
retrieving revision 1.86
retrieving revision 1.87
diff -u -d -r1.86 -r1.87
--- step.py 22 May 2006 00:50:31 -0000 1.86
+++ step.py 2 Jun 2006 03:32:23 -0000 1.87
@@ -879,6 +879,9 @@
the exit code of that command is non-zero, SUCCESS otherwise. To change
this behavior, override my .evaluateCommand method.
+ By default, a failure of this step will mark the whole build as FAILURE.
+ To override this, give me an argument of flunkOnFailure=False .
+
I create a single Log named 'log' which contains the output of the
command. To create additional summary Logs, override my .createSummary
method.
@@ -900,6 +903,10 @@
descriptionDone = None # alternate description when the step is complete
command = None # set this to a command, or set in kwargs
+ # override this on a specific ShellCommand if you want to let it fail
+ # without dooming the entire build to a status of FAILURE
+ flunkOnFailure = True
+
def __init__(self, workdir,
description=None, descriptionDone=None,
command=None,
From warner at users.sourceforge.net Fri Jun 2 03:32:25 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Fri, 02 Jun 2006 03:32:25 +0000
Subject: [Buildbot-commits] buildbot ChangeLog,1.639,1.640
Message-ID:
Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv4681
Modified Files:
ChangeLog
Log Message:
[project @ set ShellCommand.flunkOnFailure=True by default]
Original author: warner at lothar.com
Date: 2006-06-02 03:23:23
Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.639
retrieving revision 1.640
diff -u -d -r1.639 -r1.640
--- ChangeLog 30 May 2006 07:07:40 -0000 1.639
+++ ChangeLog 2 Jun 2006 03:32:23 -0000 1.640
@@ -1,3 +1,11 @@
+2006-06-01 Brian Warner
+
+ * buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
+ by default, so that any ShellCommand which fails marks the overall
+ build as a failure. I should have done this from the beginning.
+ Add flunkOnFailure=False to the arguments if you want to turn off
+ this behavior.
+
2006-05-30 Brian Warner
* buildbot/clients/gtkPanes.py: add a third row: now it shows
From warner at users.sourceforge.net Fri Jun 2 03:32:31 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Fri, 02 Jun 2006 03:32:31 +0000
Subject: [Buildbot-commits] buildbot ChangeLog,1.640,1.641
Message-ID:
Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv4716
Modified Files:
ChangeLog
Log Message:
[project @ statusgui improvements]
Original author: warner at lothar.com
Date: 2006-06-02 03:28:54
Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.640
retrieving revision 1.641
diff -u -d -r1.640 -r1.641
--- ChangeLog 2 Jun 2006 03:32:23 -0000 1.640
+++ ChangeLog 2 Jun 2006 03:32:29 -0000 1.641
@@ -1,5 +1,12 @@
2006-06-01 Brian Warner
+ * buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
+ (Box.setETA): handle ETA=None (by stopping the timer)
+ (Box.update): make the [soon] text less different than the usual
+ text, so the rest of the text doesn't flop around so much. It
+ would be awfully nice to figure out how to center this stuff.
+ (ThreeRowBuilder.stepETAUpdate): more debugging printouts
+
* buildbot/process/step.py (ShellCommand): set flunkOnFailure=True
by default, so that any ShellCommand which fails marks the overall
build as a failure. I should have done this from the beginning.
From warner at users.sourceforge.net Fri Jun 2 03:32:31 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Fri, 02 Jun 2006 03:32:31 +0000
Subject: [Buildbot-commits] buildbot/buildbot/clients gtkPanes.py, 1.11, 1.12
Message-ID:
Update of /cvsroot/buildbot/buildbot/buildbot/clients
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv4716/buildbot/clients
Modified Files:
gtkPanes.py
Log Message:
[project @ statusgui improvements]
Original author: warner at lothar.com
Date: 2006-06-02 03:28:54
Index: gtkPanes.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/clients/gtkPanes.py,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -d -r1.11 -r1.12
--- gtkPanes.py 30 May 2006 07:07:40 -0000 1.11
+++ gtkPanes.py 2 Jun 2006 03:32:29 -0000 1.12
@@ -275,11 +275,16 @@
self.label.set_text(text)
def setColor(self, color):
+ if not color:
+ return
self.box.modify_bg(gtk.STATE_NORMAL, gtk.gdk.color_parse(color))
def setETA(self, eta):
- self.when = now() + eta
- self.startTimer()
+ if eta:
+ self.when = now() + eta
+ self.startTimer()
+ else:
+ self.stopTimer()
def startTimer(self):
self.stopTimer()
@@ -300,7 +305,7 @@
return True # restart timer
else:
# done
- self.label.set_text("%s\n[soon]" % (self.text,))
+ self.label.set_text("%s\n[soon]\n[overdue]" % (self.text,))
self.timer = None
return False
@@ -376,6 +381,7 @@
self.step.setColor("white")
self.step.stopTimer()
def stepETAUpdate(self, stepname, eta):
+ print "[%s] stepETAUpdate: %s %s" % (self.name, stepname, eta)
self.step.setETA(eta)
From warner at users.sourceforge.net Fri Jun 2 05:15:48 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Fri, 02 Jun 2006 05:15:48 +0000
Subject: [Buildbot-commits] buildbot ChangeLog,1.641,1.642
Message-ID:
Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv17002
Modified Files:
ChangeLog
Log Message:
[project @ add a 'reason' tooltip to the yellow start-of-build box]
Original author: warner at lothar.com
Date: 2006-06-02 05:14:45
Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.641
retrieving revision 1.642
diff -u -d -r1.641 -r1.642
--- ChangeLog 2 Jun 2006 03:32:29 -0000 1.641
+++ ChangeLog 2 Jun 2006 05:15:46 -0000 1.642
@@ -1,5 +1,11 @@
2006-06-01 Brian Warner
+ * buildbot/status/html.py (BuildBox.getBox): set the 'title='
+ attribute of the "Build #NN" link in the yellow start-the-build
+ box to the build's reason. This means that you get a little
+ tooltip explaining why the build was done when you hover over the
+ yellow box. Thanks to Zandr Milewski for the suggestion.
+
* buildbot/clients/gtkPanes.py (Box.setColor): ignore color=None
(Box.setETA): handle ETA=None (by stopping the timer)
(Box.update): make the [soon] text less different than the usual
From warner at users.sourceforge.net Fri Jun 2 05:15:48 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Fri, 02 Jun 2006 05:15:48 +0000
Subject: [Buildbot-commits] buildbot/buildbot/status html.py,1.84,1.85
Message-ID:
Update of /cvsroot/buildbot/buildbot/buildbot/status
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv17002/buildbot/status
Modified Files:
html.py
Log Message:
[project @ add a 'reason' tooltip to the yellow start-of-build box]
Original author: warner at lothar.com
Date: 2006-06-02 05:14:45
Index: html.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/status/html.py,v
retrieving revision 1.84
retrieving revision 1.85
diff -u -d -r1.84 -r1.85
--- html.py 21 May 2006 21:28:26 -0000 1.84
+++ html.py 2 Jun 2006 05:15:46 -0000 1.85
@@ -919,7 +919,9 @@
name = b.getBuilder().getName()
number = b.getNumber()
url = "%s/builds/%d" % (urllib.quote(name, safe=''), number)
- text = 'Build %d' % (url, number)
+ reason = b.getReason()
+ text = ('Build %d'
+ % (html.escape(reason), url, number))
color = "yellow"
class_ = "start"
if b.isFinished() and not b.getSteps():
From warner at users.sourceforge.net Fri Jun 2 06:26:30 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Fri, 02 Jun 2006 06:26:30 +0000
Subject: [Buildbot-commits] buildbot/buildbot/test test_web.py,1.29,1.30
Message-ID:
Update of /cvsroot/buildbot/buildbot/buildbot/test
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv17222/buildbot/test
Modified Files:
test_web.py
Log Message:
[project @ fix test_web.py to match the title= change]
Original author: warner at lothar.com
Date: 2006-06-02 06:25:38
Index: test_web.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/test/test_web.py,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -d -r1.29 -r1.30
--- test_web.py 21 May 2006 22:38:19 -0000 1.29
+++ test_web.py 2 Jun 2006 06:26:28 -0000 1.30
@@ -398,6 +398,7 @@
bs.addStep(step1)
bs.buildStarted(build1)
step1.step_status.stepStarted()
+ bs.setReason("reason")
log1 = step1.addLog("output")
log1.addStdout("some stdout\n")
From warner at users.sourceforge.net Fri Jun 2 06:26:30 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Fri, 02 Jun 2006 06:26:30 +0000
Subject: [Buildbot-commits] buildbot ChangeLog,1.642,1.643
Message-ID:
Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv17222
Modified Files:
ChangeLog
Log Message:
[project @ fix test_web.py to match the title= change]
Original author: warner at lothar.com
Date: 2006-06-02 06:25:38
Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.642
retrieving revision 1.643
diff -u -d -r1.642 -r1.643
--- ChangeLog 2 Jun 2006 05:15:46 -0000 1.642
+++ ChangeLog 2 Jun 2006 06:26:28 -0000 1.643
@@ -1,5 +1,8 @@
2006-06-01 Brian Warner
+ * buildbot/test/test_web.py (Logfile.setUp): set the .reason on
+ the fake build, so that title= has something to be set to
+
* buildbot/status/html.py (BuildBox.getBox): set the 'title='
attribute of the "Build #NN" link in the yellow start-the-build
box to the build's reason. This means that you get a little
From warner at users.sourceforge.net Fri Jun 2 15:54:58 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Fri, 02 Jun 2006 15:54:58 +0000
Subject: [Buildbot-commits] buildbot/contrib svn_buildbot.py,1.11,1.12
Message-ID:
Update of /cvsroot/buildbot/buildbot/contrib
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv23397/contrib
Modified Files:
svn_buildbot.py
Log Message:
[project @ contrib/svn_buildbot.py: handle property changes correctly]
Original author: warner at lothar.com
Date: 2006-06-02 15:53:04
Index: svn_buildbot.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/contrib/svn_buildbot.py,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -d -r1.11 -r1.12
--- svn_buildbot.py 22 Mar 2006 20:53:30 -0000 1.11
+++ svn_buildbot.py 2 Jun 2006 15:54:56 -0000 1.12
@@ -145,7 +145,8 @@
changed = commands.getoutput('svnlook changed %s "%s"' % (rev_arg,
repo)
).split('\n')
- changed = [x[1:].strip() for x in changed]
+ # the first 6 columns can contain status information
+ changed = [x[6:].strip() for x in changed]
message = commands.getoutput('svnlook log %s "%s"' % (rev_arg, repo))
who = commands.getoutput('svnlook author %s "%s"' % (rev_arg, repo))
From warner at users.sourceforge.net Fri Jun 2 15:54:58 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Fri, 02 Jun 2006 15:54:58 +0000
Subject: [Buildbot-commits] buildbot ChangeLog,1.643,1.644
Message-ID:
Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv23397
Modified Files:
ChangeLog
Log Message:
[project @ contrib/svn_buildbot.py: handle property changes correctly]
Original author: warner at lothar.com
Date: 2006-06-02 15:53:04
Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.643
retrieving revision 1.644
diff -u -d -r1.643 -r1.644
--- ChangeLog 2 Jun 2006 06:26:28 -0000 1.643
+++ ChangeLog 2 Jun 2006 15:54:56 -0000 1.644
@@ -1,3 +1,10 @@
+2006-06-02 Brian Warner
+
+ * contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
+ first six columns of 'svnlook' output, not just the first column,
+ since property changes appear in the other five. Thanks to Olivier
+ Bonnet for the patch.
+
2006-06-01 Brian Warner
* buildbot/test/test_web.py (Logfile.setUp): set the .reason on
From warner at users.sourceforge.net Sat Jun 3 17:29:15 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Sat, 03 Jun 2006 17:29:15 +0000
Subject: [Buildbot-commits] buildbot ChangeLog,1.644,1.645
Message-ID:
Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv9215
Modified Files:
ChangeLog
Log Message:
[project @ add bug number to the svn-property-change fix]
Original author: warner at lothar.com
Date: 2006-06-03 17:28:39
Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.644
retrieving revision 1.645
diff -u -d -r1.644 -r1.645
--- ChangeLog 2 Jun 2006 15:54:56 -0000 1.644
+++ ChangeLog 3 Jun 2006 17:29:13 -0000 1.645
@@ -3,7 +3,7 @@
* contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
first six columns of 'svnlook' output, not just the first column,
since property changes appear in the other five. Thanks to Olivier
- Bonnet for the patch.
+ Bonnet for the patch. Fixes SF#1398174.
2006-06-01 Brian Warner
From warner at users.sourceforge.net Sat Jun 3 18:23:06 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Sat, 03 Jun 2006 18:23:06 +0000
Subject: [Buildbot-commits] buildbot ChangeLog,1.645,1.646
Message-ID:
Update of /cvsroot/buildbot/buildbot
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv32174
Modified Files:
ChangeLog
Log Message:
[project @ MailNotifier: don't double-escape the build URL, fixes SF#1452801]
Original author: warner at lothar.com
Date: 2006-06-03 18:20:34
Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/buildbot/ChangeLog,v
retrieving revision 1.645
retrieving revision 1.646
diff -u -d -r1.645 -r1.646
--- ChangeLog 3 Jun 2006 17:29:13 -0000 1.645
+++ ChangeLog 3 Jun 2006 18:23:04 -0000 1.646
@@ -1,3 +1,9 @@
+2006-06-03 Brian Warner
+
+ * buildbot/status/mail.py (MailNotifier.buildMessage): don't
+ double-escape the build URL. Thanks to Olivier Bonnet for the
+ patch. Fixes SF#1452801.
+
2006-06-02 Brian Warner
* contrib/svn_buildbot.py (ChangeSender.getChanges): ignore the
From warner at users.sourceforge.net Sat Jun 3 18:23:06 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Sat, 03 Jun 2006 18:23:06 +0000
Subject: [Buildbot-commits] buildbot/buildbot/status mail.py,1.24,1.25
Message-ID:
Update of /cvsroot/buildbot/buildbot/buildbot/status
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv32174/buildbot/status
Modified Files:
mail.py
Log Message:
[project @ MailNotifier: don't double-escape the build URL, fixes SF#1452801]
Original author: warner at lothar.com
Date: 2006-06-03 18:20:34
Index: mail.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/status/mail.py,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -d -r1.24 -r1.25
--- mail.py 17 Apr 2006 19:22:34 -0000 1.24
+++ mail.py 3 Jun 2006 18:23:04 -0000 1.25
@@ -233,8 +233,7 @@
text += "The Buildbot has detected a new failure of %s.\n" % name
buildurl = self.status.getURLForThing(build)
if buildurl:
- text += ("Full details are available at:\n %s\n" %
- urllib.quote(buildurl, '/:'))
+ text += "Full details are available at:\n %s\n" % buildurl
text += "\n"
url = self.status.getBuildbotURL()
From warner at users.sourceforge.net Sat Jun 3 19:40:39 2006
From: warner at users.sourceforge.net (Brian Warner)
Date: Sat, 03 Jun 2006 19:40:39 +0000
Subject: [Buildbot-commits] site ChangeLog, 1.35, 1.36 source-Arch.html, 1.8,
1.9
Message-ID:
Update of /cvsroot/buildbot/site
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv32052
Modified Files:
ChangeLog source-Arch.html
Log Message:
update source-Arch.html
Index: ChangeLog
===================================================================
RCS file: /cvsroot/buildbot/site/ChangeLog,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -d -r1.35 -r1.36
--- ChangeLog 24 May 2006 18:20:33 -0000 1.35
+++ ChangeLog 3 Jun 2006 19:40:37 -0000 1.36
@@ -1,3 +1,7 @@
+2006-06-03 Brian Warner
+
+ * source-Arch.html: update cvs-vs-arch-vs-darcs stuff
+
2006-05-24 Brian Warner
* index.html: add "Getting Buildbot" section to point at
Index: source-Arch.html
===================================================================
RCS file: /cvsroot/buildbot/site/source-Arch.html,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -d -r1.8 -r1.9
--- source-Arch.html 12 Mar 2006 08:21:01 -0000 1.8
+++ source-Arch.html 3 Jun 2006 19:40:37 -0000 1.9
@@ -11,16 +11,11 @@
In addition to CVS, the Buildbot source code is available via Arch. The archive is
experimental, but I figure this may make it slightly easier for contributors
-to track the upstream sources. More significantly, the Arch archive is
-synchronized from the CVS repository within a few minutes after each commit,
-as opposed to the 5-plus-hour delay between a commit and the time the sf.net
-anonymous CVS repository gets updated.
-
-The result is that if you wanted to (say) set up a metabuildbot (a
-Buildbot which runs the Buildbot unit test suite), and you wanted it to be
-able to test code that was a few minutes old instead of several hours old,
-you'd want to configure it to get its source code from the Arch archive
-instead of from anoncvs.
+to track the upstream sources. At the moment (03-Jun-2006), this branch is
+manually synchronized from the CVS repository, so it may be a few hours to a
+few days behind, depending upon how quickly I get back to my desk after doing
+a commit. Check the ChangeLogs in both trees to make sure they're
+up-to-date.
The Arch coordinates are as follows:
@@ -120,21 +115,20 @@
-----END PGP PUBLIC KEY BLOCK-----
-Also note that this is a two-way sync, and that when I sometimes do
-Buildbot work from a local Arch repository, those changes can get pushed into
-CVS via the same gateway. Still experimental, but it means that if you use
-Arch and want to contribute, I'll be able to pull from your archive instead
-of having you mail me patches all the time.
-
Buildbot source code via Darcs
-I also have a one-way Darcs mirror which tracks the CVS repository. To
+
The Buildbot source code is also available from a Darcs repository. To
pull a tree this way, use the following command:
-darcs get http://buildbot.sf.net/darcs-repos/trunk
+darcs get --partial http://buildbot.sf.net/darcs-repos/trunk
+The Darcs tree is the most up-to-date available. The CVS repository on
+sf.net is actually slaved to the Darcs tree (and updated automatically upon
+each Darcs checkin). The Arch repository is also slaved to the Darcs tree
+(but is updated by hand).
+
@@ -146,5 +140,5 @@
Brian Warner
<warner @ lothar.com>
-Last modified: Sat Mar 11 22:42:03 PST 2006
+Last modified: Sat Jun 3 12:38:44 PDT 2006