[Buildbot-commits] buildbot/buildbot/test test_web.py,1.25,1.26

Brian Warner warner at users.sourceforge.net
Mon Jan 23 23:03:29 UTC 2006


Update of /cvsroot/buildbot/buildbot/buildbot/test
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv11310/buildbot/test

Modified Files:
	test_web.py 
Log Message:
Revision: arch at buildbot.sf.net--2004/buildbot--dev--0--patch-460
Creator:  Brian Warner <warner at lothar.com>

allow spaces and slashes in Builder names (and their URLs)

	* buildbot/status/builder.py: urllib.quote() all URLs that include
	Builder names, so that builders can include characters like '/'
	and ' ' without completely breaking the resulting HTML. Thanks to
	Kevin Turner for the patch.
	* buildbot/status/html.py: same
	* buildbot/test/test_web.py (GetURL.testBuild): match changes


Index: test_web.py
===================================================================
RCS file: /cvsroot/buildbot/buildbot/buildbot/test/test_web.py,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -d -r1.25 -r1.26
--- test_web.py	5 Nov 2005 21:06:15 -0000	1.25
+++ test_web.py	23 Jan 2006 23:03:27 -0000	1.26
@@ -342,10 +342,10 @@
         self.assertURLEqual(build, "b1/builds/0")
         # no page for builder.getEvent(-1)
         step = build.getSteps()[0]
-        self.assertURLEqual(step, "b1/builds/0/step-remote dummy")
+        self.assertURLEqual(step, "b1/builds/0/step-remote%20dummy")
         # maybe page for build.getTestResults?
         self.assertURLEqual(step.getLogs()[0],
-                            "b1/builds/0/step-remote dummy/0")
+                            "b1/builds/0/step-remote%20dummy/0")
 
 
 





More information about the Commits mailing list